public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "mscfd at gmx dot net" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/99529] libgfortran I/O: Data races related to new unit / new unit calls for I/O to strings
Date: Thu, 11 Mar 2021 08:52:06 +0000	[thread overview]
Message-ID: <bug-99529-4-4ni2HFEOLf@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-99529-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99529

--- Comment #3 from martin <mscfd at gmx dot net> ---
Thanks for looking at the report and providing a patch to test.
For completeness sake, here is the simple test code, which does not fail, but
which shows the data race in helgrind (compile with -fopenmp -g2):

program omp_write_str

use OMP_LIB
implicit none

integer :: i
character(len=16) :: out

!$omp parallel do schedule(static,10) default(shared) private(i, out)
do i=1,100000
   write(out,'(i8)') omp_get_thread_num()
end do
!$omp end parallel do

end program omp_write_str


The provided patch indeed removes the data races (there are still data races at
startup and exit, which are false positives, as those occur in a single
threaded region.)

However, with the my real code, it does not help. I will further check with
helgrind (the amount of false positives is staggering, though...)

  parent reply	other threads:[~2021-03-11  8:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10 21:10 [Bug fortran/99529] New: " burnus at gcc dot gnu.org
2021-03-10 21:30 ` [Bug fortran/99529] " burnus at gcc dot gnu.org
2021-03-11  8:30 ` rguenth at gcc dot gnu.org
2021-03-11  8:52 ` mscfd at gmx dot net [this message]
2021-03-11  9:07 ` mscfd at gmx dot net
2021-03-11  9:31 ` burnus at gcc dot gnu.org
2021-03-11  9:48 ` burnus at gcc dot gnu.org
2021-03-15 13:29 ` burnus at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-99529-4-4ni2HFEOLf@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).