public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "burnus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/99529] libgfortran I/O: Data races related to new unit / new unit calls for I/O to strings
Date: Mon, 15 Mar 2021 13:29:17 +0000 [thread overview]
Message-ID: <bug-99529-4-h9ac8702Ik@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-99529-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99529
Tobias Burnus <burnus at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|UNCONFIRMED |RESOLVED
--- Comment #7 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Missed to add a PR fortran/99529, hence, the commit did not show up:
r11-7647-ga6e9633ccb593937fceec67fafc2afe5d518d735
commit a6e9633ccb593937fceec67fafc2afe5d518d735
Author: Tobias Burnus <tobias@codesourcery.com>
Date: Fri Mar 12 16:31:32 2021 +0100
Fortran: Fix libgfortran I/O race with newunit_free [PR99529]
libgfortran/ChangeLog:
* io/transfer.c (st_read_done_worker, st_write_done_worker):
Call unlock_unit here, add unit_lock lock around newunit_free call.
(st_read_done, st_write_done): Only call unlock_unit when not
calling the worker function.
* io/unit.c (set_internal_unit): Don't reset the unit_number
to the same number as this cause race warnings.
* * *
Committed patch was the revised version
https://gcc.gnu.org/pipermail/gcc-patches/2021-March/566600.html
Martin (who reported the issue + helped debugging it) wrote in one of the email
threads:
"BTW, I will do some more tests, but it looks like the patch fixes
the memory corruption issue."
Thus, hopefully, this issue is fixed for good. Thanks to all involved for the
help!
→ Close as FIXED (on mainline, GCC 11).
prev parent reply other threads:[~2021-03-15 13:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 21:10 [Bug fortran/99529] New: " burnus at gcc dot gnu.org
2021-03-10 21:30 ` [Bug fortran/99529] " burnus at gcc dot gnu.org
2021-03-11 8:30 ` rguenth at gcc dot gnu.org
2021-03-11 8:52 ` mscfd at gmx dot net
2021-03-11 9:07 ` mscfd at gmx dot net
2021-03-11 9:31 ` burnus at gcc dot gnu.org
2021-03-11 9:48 ` burnus at gcc dot gnu.org
2021-03-15 13:29 ` burnus at gcc dot gnu.org [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-99529-4-h9ac8702Ik@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).