public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/99648] [11 regression] gcc.dg/torture/pr71522.c fails starting with r11-165 for 32 bits
Date: Mon, 12 Apr 2021 11:30:55 +0000	[thread overview]
Message-ID: <bug-99648-4-5EWdceHmk4@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-99648-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99648

--- Comment #11 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #10)
> Created attachment 50566 [details]
> gcc11-pr99648.patch
> 
> Updated patch which doesn't ICE anymore.  While I think the right thing
> would be to always punt on SUBREGs of constants, I think that is quite risky
> this late and so restricting it to MODE_COMPOSITE_P outermodes will make it
> restricted to
> powerpc IBM double double format and nothing else (well, there is also
> mips_extended_format, but no target seems to use it fortunately).

  if (MODE_COMPOSITE_P (outermode)

7347    

      && (CONST_SCALAR_INT_P (op)

7348    

          || CONST_DOUBLE_AS_FLOAT_P (op)

7349    

          || CONST_FIXED_P (op)

7350    

          || GET_CODE (op) == CONST_VECTOR))

7351    

    return NULL_RTX;

it's odd to reject CONST_INT_P but not CONST_DOUBLE-as-int, no?  Did you
mean to do

   if (MODE_COMPOSITE_P (outermode))
     switch (GET_CODE (op))
      {
      CASE_CONST_ANY:
        return NULL_RTX;
      default:;
      }

?  (yeah, CONST_ANY_P is missing it seems)

  parent reply	other threads:[~2021-04-12 11:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-18 15:31 [Bug other/99648] New: " seurer at gcc dot gnu.org
2021-03-18 16:42 ` [Bug other/99648] " jakub at gcc dot gnu.org
2021-03-19  7:39 ` [Bug target/99648] " rguenth at gcc dot gnu.org
2021-03-30 20:01 ` seurer at gcc dot gnu.org
2021-03-30 20:06 ` seurer at gcc dot gnu.org
2021-03-31  7:41 ` rguenth at gcc dot gnu.org
2021-04-09 16:48 ` jakub at gcc dot gnu.org
2021-04-09 17:42 ` jakub at gcc dot gnu.org
2021-04-12  6:44 ` rguenth at gcc dot gnu.org
2021-04-12  9:10 ` jakub at gcc dot gnu.org
2021-04-12 10:27 ` jakub at gcc dot gnu.org
2021-04-12 11:30 ` rguenth at gcc dot gnu.org [this message]
2021-04-12 11:34 ` jakub at gcc dot gnu.org
2021-04-13  7:42 ` cvs-commit at gcc dot gnu.org
2021-04-13  7:42 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-99648-4-5EWdceHmk4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).