public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/99733] New: darwin: missing ':' in error message about munmap
@ 2021-03-23 16:44 roland.illig at gmx dot de
2021-03-23 17:11 ` [Bug target/99733] " redi at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: roland.illig at gmx dot de @ 2021-03-23 16:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99733
Bug ID: 99733
Summary: darwin: missing ':' in error message about munmap
Product: gcc
Version: 11.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: target
Assignee: unassigned at gcc dot gnu.org
Reporter: roland.illig at gmx dot de
Target Milestone: ---
config/host-darwin.c says:
> could not unmap %<pch_address_space%> %m
There is a ':' missing before the '%m'.
Plus, there is a unit test missing to demonstrate this typo.
Granted, this error message may be hard to produce anyway.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/99733] darwin: missing ':' in error message about munmap
2021-03-23 16:44 [Bug target/99733] New: darwin: missing ':' in error message about munmap roland.illig at gmx dot de
@ 2021-03-23 17:11 ` redi at gcc dot gnu.org
2021-03-23 18:52 ` egallager at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2021-03-23 17:11 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99733
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Last reconfirmed| |2021-03-23
Keywords| |diagnostic
Status|UNCONFIRMED |NEW
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/99733] darwin: missing ':' in error message about munmap
2021-03-23 16:44 [Bug target/99733] New: darwin: missing ':' in error message about munmap roland.illig at gmx dot de
2021-03-23 17:11 ` [Bug target/99733] " redi at gcc dot gnu.org
@ 2021-03-23 18:52 ` egallager at gcc dot gnu.org
2021-03-23 19:46 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: egallager at gcc dot gnu.org @ 2021-03-23 18:52 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99733
Eric Gallager <egallager at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |egallager at gcc dot gnu.org,
| |iains at gcc dot gnu.org
Blocks| |40883
Severity|normal |trivial
Referenced Bugs:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=40883
[Bug 40883] [meta-bug] Translation breakage with trivial fixes
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/99733] darwin: missing ':' in error message about munmap
2021-03-23 16:44 [Bug target/99733] New: darwin: missing ':' in error message about munmap roland.illig at gmx dot de
2021-03-23 17:11 ` [Bug target/99733] " redi at gcc dot gnu.org
2021-03-23 18:52 ` egallager at gcc dot gnu.org
@ 2021-03-23 19:46 ` cvs-commit at gcc dot gnu.org
2021-03-23 19:54 ` iains at gcc dot gnu.org
2021-03-23 22:50 ` roland.illig at gmx dot de
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-03-23 19:46 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99733
--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Iain D Sandoe <iains@gcc.gnu.org>:
https://gcc.gnu.org/g:7af8ec508f8105a4c4ea94246c1c4c25596cf6a5
commit r11-7805-g7af8ec508f8105a4c4ea94246c1c4c25596cf6a5
Author: Iain Sandoe <iain@sandoe.co.uk>
Date: Tue Mar 23 19:42:36 2021 +0000
Darwin : Address a translation comment.
Add a ':' to make the diagnostic read 'pch_address_space': xxx.
gcc/ChangeLog:
PR target/99733
* config/host-darwin.c (darwin_gt_pch_use_address): Add a
colon to the diagnostic message.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/99733] darwin: missing ':' in error message about munmap
2021-03-23 16:44 [Bug target/99733] New: darwin: missing ':' in error message about munmap roland.illig at gmx dot de
` (2 preceding siblings ...)
2021-03-23 19:46 ` cvs-commit at gcc dot gnu.org
@ 2021-03-23 19:54 ` iains at gcc dot gnu.org
2021-03-23 22:50 ` roland.illig at gmx dot de
4 siblings, 0 replies; 6+ messages in thread
From: iains at gcc dot gnu.org @ 2021-03-23 19:54 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99733
Iain Sandoe <iains at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #2 from Iain Sandoe <iains at gcc dot gnu.org> ---
(In reply to Roland Illig from comment #0)
> config/host-darwin.c says:
> > could not unmap %<pch_address_space%> %m
>
> There is a ':' missing before the '%m'.
(I changed this to avoid a diagnostic about "unquoted identifier or keyword".)
Personally, I would have preferred "'pch_address_space' : " but that triggers
another warning about punctuation in diagnostics. So I left the colon out (on
purpose, it was not an accident ;) ).
However, I have not a strong feeling about it - and if it helps translation to
leave it in all OK with me.
So we have now got "'pch_address_space': "
> Plus, there is a unit test missing to demonstrate this typo.
> Granted, this error message may be hard to produce anyway.
Yeah, I don't know a reasonable way to do that.
As noted in the commit message for the change I am not sure that the message is
really a worthwhile end-user one, since there's nothing that they can do about
it - however, fixing that is not something for stage 4.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/99733] darwin: missing ':' in error message about munmap
2021-03-23 16:44 [Bug target/99733] New: darwin: missing ':' in error message about munmap roland.illig at gmx dot de
` (3 preceding siblings ...)
2021-03-23 19:54 ` iains at gcc dot gnu.org
@ 2021-03-23 22:50 ` roland.illig at gmx dot de
4 siblings, 0 replies; 6+ messages in thread
From: roland.illig at gmx dot de @ 2021-03-23 22:50 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99733
--- Comment #3 from Roland Illig <roland.illig at gmx dot de> ---
(In reply to Iain Sandoe from comment #2)
> Personally, I would have preferred "'pch_address_space' : " but that
> triggers another warning about punctuation in diagnostics. So I left the
> colon out (on purpose, it was not an accident ;) ).
It should have been as simple as writing %<pch_address_space%> instead of
'pch_address_space'. Wasn't the diagnostic clear enough? Martin Sebor did put
a lot of work into making the diagnostics uniform in style in 2019.
>From c-format.c:
> inform (format_string_loc,
> "if avoiding the apostrophe is not feasible, enclose "
> "it in a pair of %qs and %qs directives instead",
> "%<", "%>");
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-03-23 22:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-23 16:44 [Bug target/99733] New: darwin: missing ':' in error message about munmap roland.illig at gmx dot de
2021-03-23 17:11 ` [Bug target/99733] " redi at gcc dot gnu.org
2021-03-23 18:52 ` egallager at gcc dot gnu.org
2021-03-23 19:46 ` cvs-commit at gcc dot gnu.org
2021-03-23 19:54 ` iains at gcc dot gnu.org
2021-03-23 22:50 ` roland.illig at gmx dot de
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).