public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/99927] [11 Regression] Maybe wrong code since r11-39-gf9e1ea10e657af9f
Date: Tue, 06 Apr 2021 15:37:05 +0000 [thread overview]
Message-ID: <bug-99927-4-B6ioO1cZx9@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-99927-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99927
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|jakub at gcc dot gnu.org |unassigned at gcc dot gnu.org
Status|ASSIGNED |NEW
--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Ah, create_log_links wants to work like that.
So, the bug seems to be that insn 108 has REG_DEAD (reg:CC 17 flags) note.
It doesn't initially, but it is added during 106 -> 108 combination
(gdb) p debug_rtx (i3)
(insn 108 107 111 6 (set (reg:QI 96 [ var_lsm_flag.12 ])
(if_then_else:QI (eq (reg:CCZ 17 flags)
(const_int 0 [0]))
(reg:QI 134)
(reg:QI 135))) "pr99927.c":13:24 1104 {*movqicc_noc}
(expr_list:REG_DEAD (reg:QI 134)
(nil)))
$151 = void
(gdb) p debug_rtx (i2)
(insn 106 105 107 6 (parallel [
(set (reg:QI 134)
(and:QI (subreg:QI (reg:SI 107) 0)
(const_int 1 [0x1])))
(clobber (reg:CC 17 flags))
]) "pr99927.c":13:24 491 {*andqi_1}
(expr_list:REG_UNUSED (reg:CC 17 flags)
(nil)))
The combination of those 2 insns is successful - into:
(insn 108 107 111 6 (set (reg:QI 96 [ var_lsm_flag.12 ])
(if_then_else:QI (eq (reg:CCZ 17 flags)
(const_int 0 [0]))
(subreg:QI (reg:SI 107) 0)
(reg:QI 135))) "pr99927.c":13:24 1104 {*movqicc_noc}
(expr_list:REG_DEAD (reg:SI 107)
(expr_list:REG_DEAD (reg:CC 17 flags)
(nil))))
but the distribute_notes that turned REG_UNUSED (reg:CC 17 flags) note from
insn 106 into REG_DEAD (reg:CC 17 flags) note on insn 108 is what looks broken
to me,
the flags register is set by insn 107 in between those two and is used by some
insns after insn 108 (111 and 85) and the new combined pattern certainly
doesn't
kill the register in any way.
Segher, could you please have a look?
Thanks.
next prev parent reply other threads:[~2021-04-06 15:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 8:22 [Bug tree-optimization/99927] New: " marxin at gcc dot gnu.org
2021-04-06 8:54 ` [Bug tree-optimization/99927] " rguenth at gcc dot gnu.org
2021-04-06 13:57 ` jakub at gcc dot gnu.org
2021-04-06 14:02 ` jakub at gcc dot gnu.org
2021-04-06 14:17 ` rguenth at gcc dot gnu.org
2021-04-06 14:44 ` jakub at gcc dot gnu.org
2021-04-06 15:03 ` jakub at gcc dot gnu.org
2021-04-06 15:37 ` jakub at gcc dot gnu.org [this message]
2021-04-06 15:42 ` jakub at gcc dot gnu.org
2021-04-06 19:59 ` segher at gcc dot gnu.org
2021-04-06 20:05 ` jakub at gcc dot gnu.org
2021-04-07 17:38 ` [Bug tree-optimization/99927] [11 Regression] Wrong " segher at gcc dot gnu.org
2021-04-07 17:46 ` jakub at gcc dot gnu.org
2021-04-07 18:09 ` segher at gcc dot gnu.org
2021-04-08 2:39 ` segher at gcc dot gnu.org
2021-04-12 14:21 ` rguenth at gcc dot gnu.org
2021-04-12 18:00 ` segher at gcc dot gnu.org
2021-04-18 15:01 ` cvs-commit at gcc dot gnu.org
2021-04-18 15:08 ` [Bug rtl-optimization/99927] " segher at gcc dot gnu.org
2021-04-27 11:40 ` jakub at gcc dot gnu.org
2021-04-29 10:44 ` rguenth at gcc dot gnu.org
2021-07-19 16:07 ` [Bug rtl-optimization/99927] [9/10 only] " pinskia at gcc dot gnu.org
2021-07-19 16:07 ` pinskia at gcc dot gnu.org
2021-07-19 17:13 ` cvs-commit at gcc dot gnu.org
2021-07-19 17:15 ` cvs-commit at gcc dot gnu.org
2021-07-19 17:16 ` segher at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-99927-4-B6ioO1cZx9@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).