public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/99927] [11 Regression] Maybe wrong code since r11-39-gf9e1ea10e657af9f
Date: Tue, 06 Apr 2021 15:42:48 +0000	[thread overview]
Message-ID: <bug-99927-4-dKvnvObwmF@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-99927-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99927

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
distribute_notes has:
          /* If this register is set or clobbered in I3, put the note there
             unless there is one already.  */
          if (reg_set_p (XEXP (note, 0), PATTERN (i3)))
            {
              if (from_insn != i3)
                break;

              if (! (REG_P (XEXP (note, 0))
                     ? find_regno_note (i3, REG_UNUSED, REGNO (XEXP (note, 0)))
                     : find_reg_note (i3, REG_UNUSED, XEXP (note, 0))))
                place = i3;
            }
          /* Otherwise, if this register is used by I3, then this register
             now dies here, so we must put a REG_DEAD note here unless there
             is one already.  */
          else if (reg_referenced_p (XEXP (note, 0), PATTERN (i3))
                   && ! (REG_P (XEXP (note, 0))
                         ? find_regno_note (i3, REG_DEAD,
                                            REGNO (XEXP (note, 0)))
                         : find_reg_note (i3, REG_DEAD, XEXP (note, 0))))
            {
              PUT_REG_NOTE_KIND (note, REG_DEAD);
              place = i3;
            }
the if (reg_set_p (...)) is false, as flags is not set by the insn, it is used.
But the else if is clearly not true, at least when XEXP (note, 0) is set in
instructions in between i3 and i2 (or from whatever insn the notes come from).

  parent reply	other threads:[~2021-04-06 15:42 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-06  8:22 [Bug tree-optimization/99927] New: " marxin at gcc dot gnu.org
2021-04-06  8:54 ` [Bug tree-optimization/99927] " rguenth at gcc dot gnu.org
2021-04-06 13:57 ` jakub at gcc dot gnu.org
2021-04-06 14:02 ` jakub at gcc dot gnu.org
2021-04-06 14:17 ` rguenth at gcc dot gnu.org
2021-04-06 14:44 ` jakub at gcc dot gnu.org
2021-04-06 15:03 ` jakub at gcc dot gnu.org
2021-04-06 15:37 ` jakub at gcc dot gnu.org
2021-04-06 15:42 ` jakub at gcc dot gnu.org [this message]
2021-04-06 19:59 ` segher at gcc dot gnu.org
2021-04-06 20:05 ` jakub at gcc dot gnu.org
2021-04-07 17:38 ` [Bug tree-optimization/99927] [11 Regression] Wrong " segher at gcc dot gnu.org
2021-04-07 17:46 ` jakub at gcc dot gnu.org
2021-04-07 18:09 ` segher at gcc dot gnu.org
2021-04-08  2:39 ` segher at gcc dot gnu.org
2021-04-12 14:21 ` rguenth at gcc dot gnu.org
2021-04-12 18:00 ` segher at gcc dot gnu.org
2021-04-18 15:01 ` cvs-commit at gcc dot gnu.org
2021-04-18 15:08 ` [Bug rtl-optimization/99927] " segher at gcc dot gnu.org
2021-04-27 11:40 ` jakub at gcc dot gnu.org
2021-04-29 10:44 ` rguenth at gcc dot gnu.org
2021-07-19 16:07 ` [Bug rtl-optimization/99927] [9/10 only] " pinskia at gcc dot gnu.org
2021-07-19 16:07 ` pinskia at gcc dot gnu.org
2021-07-19 17:13 ` cvs-commit at gcc dot gnu.org
2021-07-19 17:15 ` cvs-commit at gcc dot gnu.org
2021-07-19 17:16 ` segher at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-99927-4-dKvnvObwmF@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).