public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-1528] testsuite: Use noipa attribute instead of noinline, noclone
@ 2021-06-16 11:15 Jakub Jelinek
  0 siblings, 0 replies; only message in thread
From: Jakub Jelinek @ 2021-06-16 11:15 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:a490b1dc0b3c26bff2ee00ac0da2d606d2009e3a

commit r12-1528-ga490b1dc0b3c26bff2ee00ac0da2d606d2009e3a
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Jun 16 13:10:48 2021 +0200

    testsuite: Use noipa attribute instead of noinline, noclone
    
    I've noticed this test now on various arches sometimes FAILs, sometimes
    PASSes (the line 12 test in particular).
    
    The problem is that a = 0; initialization in the caller no longer happens
    before the f(&a) call as what the argument points to is only used in
    debug info.
    
    Making the function noipa forces the caller to initialize it and still
    tests what the test wants to test, namely that we don't consider *p as
    valid location for the c variable at line 18 (after it has been overwritten
    with *p = 1;).
    
    2021-06-16  Jakub Jelinek  <jakub@redhat.com>
    
            * gcc.dg/guality/pr49888.c (f): Use noipa attribute instead of
            noinline, noclone.

Diff:
---
 gcc/testsuite/gcc.dg/guality/pr49888.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/gcc.dg/guality/pr49888.c b/gcc/testsuite/gcc.dg/guality/pr49888.c
index 4f3a2501eb7..919cfc9c769 100644
--- a/gcc/testsuite/gcc.dg/guality/pr49888.c
+++ b/gcc/testsuite/gcc.dg/guality/pr49888.c
@@ -4,7 +4,7 @@
 
 static int v __attribute__((used));
 
-static void __attribute__((noinline, noclone))
+static void __attribute__((noipa))
 f (int *p)
 {
   int c = *p;


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-06-16 11:15 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-16 11:15 [gcc r12-1528] testsuite: Use noipa attribute instead of noinline, noclone Jakub Jelinek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).