public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-3232] Fix PR 90142: contrib/download_prerequisites uses test ==
@ 2021-08-30 20:54 Andrew Pinski
0 siblings, 0 replies; only message in thread
From: Andrew Pinski @ 2021-08-30 20:54 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:79a017c412b412f26ec39e0ada75e247fcff5611
commit r12-3232-g79a017c412b412f26ec39e0ada75e247fcff5611
Author: Andrew Pinski <apinski@marvell.com>
Date: Mon Aug 30 20:30:41 2021 +0000
Fix PR 90142: contrib/download_prerequisites uses test ==
Since == is not portable, it is better to use = in contrib/
download_prerequisites. The only place == was used is inside
the function md5_check which is used only on Mac OS X.
Tested on Mac OS X as:
./contrib/download_prerequisites --md5
Both with all files having the correct checksum and one with a broken one.
contrib/ChangeLog:
* download_prerequisites (md5_check): Replace == inside
test with = to be more portable.
Diff:
---
contrib/download_prerequisites | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/download_prerequisites b/contrib/download_prerequisites
index 8f69b61f5a9..11c283ecb1a 100755
--- a/contrib/download_prerequisites
+++ b/contrib/download_prerequisites
@@ -113,7 +113,7 @@ md5_check() {
md5_checksum_output=$(md5 -r "${file_to_check}")
# Grab the text before the first space
md5_checksum_detected="${md5_checksum_output%% *}"
- [ "${md5_checksum_expected}" == "${md5_checksum_detected}" ] \
+ [ "${md5_checksum_expected}" = "${md5_checksum_detected}" ] \
|| die "Cannot verify integrity of possibly corrupted file ${file_to_check}"
echo "${file_to_check}: OK"
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-08-30 20:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-30 20:54 [gcc r12-3232] Fix PR 90142: contrib/download_prerequisites uses test == Andrew Pinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).