[gcc r12-5031] [Ada] Cleanup copying of parameter lists

[gcc r12-5031] [Ada] Cleanup copying of parameter lists

[Pierre-Marie de Rodat]

https://gcc.gnu.org/g:7751c73202f1f1336769607b0cd5cf516e29089a

commit r12-5031-g7751c73202f1f1336769607b0cd5cf516e29089a
Author: Piotr Trojanek <trojanek@adacore.com>
Date:   Wed Oct 27 20:58:37 2021 +0200

    [Ada] Cleanup copying of parameter lists
    
    gcc/ada/
    
            * sem_util.adb (Copy_Parameter_List): Refactor to remove
            repeated calls to First_Formal.

Diff:
---
 gcc/ada/sem_util.adb | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/gcc/ada/sem_util.adb b/gcc/ada/sem_util.adb
index 8785e2e140c..bc51a60ccf2 100644
--- a/gcc/ada/sem_util.adb
+++ b/gcc/ada/sem_util.adb
@@ -6797,14 +6797,11 @@ package body Sem_Util is
    function Copy_Parameter_List (Subp_Id : Entity_Id) return List_Id is
       Loc    : constant Source_Ptr := Sloc (Subp_Id);
       Plist  : List_Id;
-      Formal : Entity_Id;
+      Formal : Entity_Id := First_Formal (Subp_Id);
 
    begin
-      if No (First_Formal (Subp_Id)) then
-         return No_List;
-      else
-         Plist  := New_List;
-         Formal := First_Formal (Subp_Id);
+      if Present (Formal) then
+         Plist := New_List;
          while Present (Formal) loop
             Append_To (Plist,
               Make_Parameter_Specification (Loc,
@@ -6819,6 +6816,8 @@ package body Sem_Util is
 
             Next_Formal (Formal);
          end loop;
+      else
+         Plist := No_List;
       end if;
 
       return Plist;