public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Richard Sandiford <rsandifo@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-5609] vect: Fix SVE mask_gather_load/store_store tests Date: Tue, 30 Nov 2021 09:53:47 +0000 (GMT) [thread overview] Message-ID: <20211130095347.0B19B385B83E@sourceware.org> (raw) https://gcc.gnu.org/g:8bb81b3c4945dbae8d490e7a4054ddeb5a3b506c commit r12-5609-g8bb81b3c4945dbae8d490e7a4054ddeb5a3b506c Author: Richard Sandiford <richard.sandiford@arm.com> Date: Tue Nov 30 09:52:28 2021 +0000 vect: Fix SVE mask_gather_load/store_store tests If-conversion now applies rewrite_to_defined_overflow to the address calculation in an IFN_MASK_LOAD. This means that we end up with: cast_base = (uintptr_t) base; uncast_sum = cast_base + offset; sum = (orig_type *) uncast_sum; If the target supports IFN_MASK_GATHER_LOAD with pointer-sized offsets for the given vectype, we wouldn't look through the sum cast and so would needlessly vectorise the uncast_sum addition. This showed up as several failures in gcc.target/aarch64/sve. gcc/ * tree-vect-data-refs.c (vect_check_gather_scatter): Continue processing conversions if the current offset is a pointer. Diff: --- gcc/tree-vect-data-refs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/tree-vect-data-refs.c b/gcc/tree-vect-data-refs.c index f1d7f01a9ce..888ad72f3a9 100644 --- a/gcc/tree-vect-data-refs.c +++ b/gcc/tree-vect-data-refs.c @@ -4139,6 +4139,7 @@ vect_check_gather_scatter (stmt_vec_info stmt_info, loop_vec_info loop_vinfo, /* Don't include the conversion if the target is happy with the current offset type. */ if (use_ifn_p + && !POINTER_TYPE_P (TREE_TYPE (off)) && vect_gather_scatter_fn_p (loop_vinfo, DR_IS_READ (dr), masked_p, vectype, memory_type, TREE_TYPE (off), scale, &ifn,
reply other threads:[~2021-11-30 9:53 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211130095347.0B19B385B83E@sourceware.org \ --to=rsandifo@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).