public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-5609] vect: Fix SVE mask_gather_load/store_store tests
@ 2021-11-30  9:53 Richard Sandiford
  0 siblings, 0 replies; only message in thread
From: Richard Sandiford @ 2021-11-30  9:53 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:8bb81b3c4945dbae8d490e7a4054ddeb5a3b506c

commit r12-5609-g8bb81b3c4945dbae8d490e7a4054ddeb5a3b506c
Author: Richard Sandiford <richard.sandiford@arm.com>
Date:   Tue Nov 30 09:52:28 2021 +0000

    vect: Fix SVE mask_gather_load/store_store tests
    
    If-conversion now applies rewrite_to_defined_overflow to the
    address calculation in an IFN_MASK_LOAD.  This means that we
    end up with:
    
        cast_base = (uintptr_t) base;
        uncast_sum = cast_base + offset;
        sum = (orig_type *) uncast_sum;
    
    If the target supports IFN_MASK_GATHER_LOAD with pointer-sized
    offsets for the given vectype, we wouldn't look through the sum
    cast and so would needlessly vectorise the uncast_sum addition.
    
    This showed up as several failures in gcc.target/aarch64/sve.
    
    gcc/
            * tree-vect-data-refs.c (vect_check_gather_scatter): Continue
            processing conversions if the current offset is a pointer.

Diff:
---
 gcc/tree-vect-data-refs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gcc/tree-vect-data-refs.c b/gcc/tree-vect-data-refs.c
index f1d7f01a9ce..888ad72f3a9 100644
--- a/gcc/tree-vect-data-refs.c
+++ b/gcc/tree-vect-data-refs.c
@@ -4139,6 +4139,7 @@ vect_check_gather_scatter (stmt_vec_info stmt_info, loop_vec_info loop_vinfo,
 	  /* Don't include the conversion if the target is happy with
 	     the current offset type.  */
 	  if (use_ifn_p
+	      && !POINTER_TYPE_P (TREE_TYPE (off))
 	      && vect_gather_scatter_fn_p (loop_vinfo, DR_IS_READ (dr),
 					   masked_p, vectype, memory_type,
 					   TREE_TYPE (off), scale, &ifn,


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-11-30  9:53 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-30  9:53 [gcc r12-5609] vect: Fix SVE mask_gather_load/store_store tests Richard Sandiford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).