public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Hans-Peter Nilsson <hp@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r12-6511] cris: Parenthesize parameter to as_a.
Date: Wed, 12 Jan 2022 02:51:42 +0000 (GMT)	[thread overview]
Message-ID: <20220112025142.DF9763858416@sourceware.org> (raw)

https://gcc.gnu.org/g:f8feccb8b08a42fa44caff69c8d82860caef3574

commit r12-6511-gf8feccb8b08a42fa44caff69c8d82860caef3574
Author: Hans-Peter Nilsson <hp@axis.com>
Date:   Wed Jan 12 02:07:13 2022 +0100

    cris: Parenthesize parameter to as_a.
    
    Noted by Richard Sandiford in
    https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103974#c7 (thanks!)
    
    Mea culpa: I wrongly thought the default development-level value
    ("yes,extra") would include everything interesting to normal target
    hacking (i.e. as opposed to hacking stuff like GC).  I see
    rtl-checking is marked as "expensive" and presumably therefore left
    out.  Maybe it could be split into rtl-static (cheap; catching type
    errors including this kind of foulups) and rtl-dynamic (the expensive
    parts).  I suppose that's for whomever feels a strong enough itch.
    
    A quick (error-prone) grep-and-eyeball in config/ shows this was the
    only file missing the parenthesis.  This lets cris-elf configured with
    --enable-checking=yes,extra,rtl survive make all-gcc.
    
    2022-01-11  Hans-Peter Nilsson  <hp@axis.com>
    
            * config/cris/cris.c (cris_postdbr_cmpelim): Parenthesize
            parameter to as_a.

Diff:
---
 gcc/config/cris/cris.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/config/cris/cris.c b/gcc/config/cris/cris.c
index eff58435789..ac1fc4909fc 100644
--- a/gcc/config/cris/cris.c
+++ b/gcc/config/cris/cris.c
@@ -392,7 +392,7 @@ cris_postdbr_cmpelim ()
       /* Consider filled delay slots; there might be a comparison there.
 	 It's only the second insn in a sequence that is interesting.  */
       if (GET_CODE (pat) == SEQUENCE)
-	insn = as_a <rtx_insn *> XVECEXP (pat, 0, 1);
+	insn = as_a <rtx_insn *> (XVECEXP (pat, 0, 1));
       /* The "else" eliminates temptations to consider an insn in a
 	 delay slot for elimination; it can only be a prev_cc_setter.  */
       else if (prev_cc_setter != 0 && GET_CODE (pat) == SET)


                 reply	other threads:[~2022-01-12  2:51 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220112025142.DF9763858416@sourceware.org \
    --to=hp@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).