public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-6511] cris: Parenthesize parameter to as_a.
@ 2022-01-12 2:51 Hans-Peter Nilsson
0 siblings, 0 replies; only message in thread
From: Hans-Peter Nilsson @ 2022-01-12 2:51 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:f8feccb8b08a42fa44caff69c8d82860caef3574
commit r12-6511-gf8feccb8b08a42fa44caff69c8d82860caef3574
Author: Hans-Peter Nilsson <hp@axis.com>
Date: Wed Jan 12 02:07:13 2022 +0100
cris: Parenthesize parameter to as_a.
Noted by Richard Sandiford in
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103974#c7 (thanks!)
Mea culpa: I wrongly thought the default development-level value
("yes,extra") would include everything interesting to normal target
hacking (i.e. as opposed to hacking stuff like GC). I see
rtl-checking is marked as "expensive" and presumably therefore left
out. Maybe it could be split into rtl-static (cheap; catching type
errors including this kind of foulups) and rtl-dynamic (the expensive
parts). I suppose that's for whomever feels a strong enough itch.
A quick (error-prone) grep-and-eyeball in config/ shows this was the
only file missing the parenthesis. This lets cris-elf configured with
--enable-checking=yes,extra,rtl survive make all-gcc.
2022-01-11 Hans-Peter Nilsson <hp@axis.com>
* config/cris/cris.c (cris_postdbr_cmpelim): Parenthesize
parameter to as_a.
Diff:
---
gcc/config/cris/cris.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/config/cris/cris.c b/gcc/config/cris/cris.c
index eff58435789..ac1fc4909fc 100644
--- a/gcc/config/cris/cris.c
+++ b/gcc/config/cris/cris.c
@@ -392,7 +392,7 @@ cris_postdbr_cmpelim ()
/* Consider filled delay slots; there might be a comparison there.
It's only the second insn in a sequence that is interesting. */
if (GET_CODE (pat) == SEQUENCE)
- insn = as_a <rtx_insn *> XVECEXP (pat, 0, 1);
+ insn = as_a <rtx_insn *> (XVECEXP (pat, 0, 1));
/* The "else" eliminates temptations to consider an insn in a
delay slot for elimination; it can only be a prev_cc_setter. */
else if (prev_cc_setter != 0 && GET_CODE (pat) == SET)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-01-12 2:51 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-12 2:51 [gcc r12-6511] cris: Parenthesize parameter to as_a Hans-Peter Nilsson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).