public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-1190] libgomp: Fix up target-31.c test [PR106045]
@ 2022-06-21 15:57 Jakub Jelinek
0 siblings, 0 replies; only message in thread
From: Jakub Jelinek @ 2022-06-21 15:57 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:85d613da341b76308edea48359a5dbc7061937c4
commit r13-1190-g85d613da341b76308edea48359a5dbc7061937c4
Author: Jakub Jelinek <jakub@redhat.com>
Date: Tue Jun 21 17:51:08 2022 +0200
libgomp: Fix up target-31.c test [PR106045]
The i variable is used inside of the parallel in:
#pragma omp simd safelen(32) private (v)
for (i = 0; i < 64; i++)
{
v = 3 * i;
ll[i] = u1 + v * u2[0] + u2[1] + x + y[0] + y[1] + v + h[0] + u3[i];
}
where i is predetermined linear (so while inside of the body
it is safe, private per SIMD lane var) the final value is written to
the shared variable, and in:
for (i = 0; i < 64; i++)
if (ll[i] != u1 + 3 * i * u2[0] + u2[1] + x + y[0] + y[1] + 3 * i + 13 + 14 + i)
#pragma omp atomic write
err = 1;
which is a normal loop and so it isn't in any way privatized there.
So we have a data race, fixed by adding private (i) clause to the
parallel.
2022-06-21 Jakub Jelinek <jakub@redhat.com>
Paul Iannetta <piannetta@kalrayinc.com>
PR libgomp/106045
* testsuite/libgomp.c/target-31.c: Add private (i) clause.
Diff:
---
libgomp/testsuite/libgomp.c/target-31.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libgomp/testsuite/libgomp.c/target-31.c b/libgomp/testsuite/libgomp.c/target-31.c
index 8e63d286b43..1123b7ea561 100644
--- a/libgomp/testsuite/libgomp.c/target-31.c
+++ b/libgomp/testsuite/libgomp.c/target-31.c
@@ -76,7 +76,7 @@ main ()
m[1] += 3 * b;
}
use (&a, &b, &c, &d, e, f, g, h);
- #pragma omp parallel firstprivate (u1, u2)
+ #pragma omp parallel firstprivate (u1, u2) private (i)
{
int w = omp_get_thread_num ();
int x = 19;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-06-21 15:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-21 15:57 [gcc r13-1190] libgomp: Fix up target-31.c test [PR106045] Jakub Jelinek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).