public inbox for
help / color / mirror / Atom feed
* [gcc r13-2663] [PR106936] Remove assert from get_value_range.
@ 2022-09-14 12:49 Aldy Hernandez
  0 siblings, 0 replies; only message in thread
From: Aldy Hernandez @ 2022-09-14 12:49 UTC (permalink / raw)
  To: gcc-cvs

commit r13-2663-g12a8d5e2f2e7d7535115e4e105c0f9eb4d50fdad
Author: Aldy Hernandez <>
Date:   Wed Sep 14 14:48:36 2022 +0200

    [PR106936] Remove assert from get_value_range.
    This assert was put here to make sure that the legacy
    get_value_range() wasn't being called on stuff that legacy couldn't
    handle (floats, etc), because the result would ultimately be copied
    into a value_range_equiv.
    In this case, simplify_casted_cond() is calling it on an offset_type
    which is neither an integer nor a pointer.  However, range_of_expr
    happily punted on it, and then the fallthru code set the range to
    VARYING.  As value_range_equiv can store VARYING types of anything
    (including types it can't handle), this is fine.
    The easiest thing to do is remove the assert.  If someone from the non
    legacy world tries to get a non integer/pointer range here, it's going
    to blow up anyhow because the temporary in get_value_range is
            PR tree-optimization/106936
            * (range_query::get_value_range): Remove assert.
            * g++.dg/tree-ssa/pr106936.C: New test.

 gcc/testsuite/g++.dg/tree-ssa/pr106936.C | 14 ++++++++++++++
 gcc/                       |  1 -
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/gcc/testsuite/g++.dg/tree-ssa/pr106936.C b/gcc/testsuite/g++.dg/tree-ssa/pr106936.C
new file mode 100644
index 00000000000..c3096e0dd20
--- /dev/null
+++ b/gcc/testsuite/g++.dg/tree-ssa/pr106936.C
@@ -0,0 +1,14 @@
+// { dg-do compile } */
+// { dg-options "-O2 -fno-tree-ccp -fno-tree-forwprop -fno-tree-fre" }
+namespace testPointerToMemberMiscCasts2 {
+struct B {
+  int f;
+struct L : public B { };
+struct R : public B { };
+struct D : public L, R { };
+  int B::* pb = &B::f;
+  int R::* pr = pb;
+  int D::* pdr = pr;
diff --git a/gcc/ b/gcc/
index 201f679a36e..ad80db780c2 100644
--- a/gcc/
+++ b/gcc/
@@ -167,7 +167,6 @@ range_query::free_value_range_equiv (value_range_equiv *v)
 const class value_range_equiv *
 range_query::get_value_range (const_tree expr, gimple *stmt)
-  gcc_checking_assert (value_range_equiv::supports_p (TREE_TYPE (expr)));
   int_range_max r;
   if (range_of_expr (r, const_cast<tree> (expr), stmt))
     return new (equiv_alloc->allocate ()) value_range_equiv (r);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-09-14 12:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-14 12:49 [gcc r13-2663] [PR106936] Remove assert from get_value_range Aldy Hernandez

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).