public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-3547] vect: Reject non-byte offsets for gather/scatters [PR107346]
@ 2022-10-28 14:09 Andre Simoes Dias Vieira
0 siblings, 0 replies; only message in thread
From: Andre Simoes Dias Vieira @ 2022-10-28 14:09 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:95decac3ce8c8c7c5302cd6fac005a10463de165
commit r13-3547-g95decac3ce8c8c7c5302cd6fac005a10463de165
Author: Andre Vieira <andre.simoesdiasvieira@arm.com>
Date: Fri Oct 28 15:05:11 2022 +0100
vect: Reject non-byte offsets for gather/scatters [PR107346]
The ada failure reported in the PR was being caused by vect_check_gather_scatter
failing to deal with bit offsets that weren't multiples of BITS_PER_UNIT. This
patch makes vect_check_gather_scatter reject memory accesses with such offsets.
gcc/ChangeLog:
PR tree-optimization/107346
* tree-vect-data-refs.cc (vect_check_gather_scatter): Reject offsets
that aren't multiples of BITS_PER_UNIT.
Diff:
---
gcc/tree-vect-data-refs.cc | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/gcc/tree-vect-data-refs.cc b/gcc/tree-vect-data-refs.cc
index 4a23d6172aa..6c892791bd4 100644
--- a/gcc/tree-vect-data-refs.cc
+++ b/gcc/tree-vect-data-refs.cc
@@ -4016,6 +4016,11 @@ vect_check_gather_scatter (stmt_vec_info stmt_info, loop_vec_info loop_vinfo,
if (reversep)
return false;
+ /* PR 107346. Packed structs can have fields at offsets that are not
+ multiples of BITS_PER_UNIT. Do not use gather/scatters in such cases. */
+ if (!multiple_p (pbitpos, BITS_PER_UNIT))
+ return false;
+
poly_int64 pbytepos = exact_div (pbitpos, BITS_PER_UNIT);
if (TREE_CODE (base) == MEM_REF)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-10-28 14:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-28 14:09 [gcc r13-3547] vect: Reject non-byte offsets for gather/scatters [PR107346] Andre Simoes Dias Vieira
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).