public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-3701] Plug memory leak in attribute target_clones
@ 2022-11-06 0:53 Bernhard Reutner-Fischer
0 siblings, 0 replies; only message in thread
From: Bernhard Reutner-Fischer @ 2022-11-06 0:53 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:07b0096e5b6749d88f5a22f694401abd6aaca551
commit r13-3701-g07b0096e5b6749d88f5a22f694401abd6aaca551
Author: Bernhard Reutner-Fischer <aldot@gcc.gnu.org>
Date: Thu Nov 3 21:52:51 2022 +0100
Plug memory leak in attribute target_clones
It looks like there was some memory leak in the handling
of attribute target_clones.
Ok for trunk if testing passes?
gcc/ChangeLog:
* multiple_target.cc (expand_target_clones): Free memory.
Signed-off-by: Bernhard Reutner-Fischer <aldot@gcc.gnu.org>
Diff:
---
gcc/multiple_target.cc | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/gcc/multiple_target.cc b/gcc/multiple_target.cc
index 67866a7c963..77e0f21dd05 100644
--- a/gcc/multiple_target.cc
+++ b/gcc/multiple_target.cc
@@ -390,19 +390,23 @@ expand_target_clones (struct cgraph_node *node, bool definition)
for (i = 0; i < attrnum; i++)
{
char *attr = attrs[i];
- char *suffix = XNEWVEC (char, strlen (attr) + 1);
- create_new_asm_name (attr, suffix);
/* Create new target clone. */
tree attributes = make_attribute ("target", attr,
DECL_ATTRIBUTES (node->decl));
+ char *suffix = XNEWVEC (char, strlen (attr) + 1);
+ create_new_asm_name (attr, suffix);
cgraph_node *new_node = create_target_clone (node, definition, suffix,
attributes);
+ XDELETEVEC (suffix);
if (new_node == NULL)
- return false;
+ {
+ XDELETEVEC (attrs);
+ XDELETEVEC (attr_str);
+ return false;
+ }
new_node->local = false;
- XDELETEVEC (suffix);
decl2_v = new_node->function_version ();
if (decl2_v != NULL)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-11-06 0:53 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-06 0:53 [gcc r13-3701] Plug memory leak in attribute target_clones Bernhard Reutner-Fischer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).