public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc(refs/vendors/vrull/heads/for-upstream)] RISC-V: Support immediates in XVentanaCondOps
@ 2022-11-15 14:02 Philipp Tomsich
0 siblings, 0 replies; 7+ messages in thread
From: Philipp Tomsich @ 2022-11-15 14:02 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:a86a5f153a5e81a50912fba3a3eaa74a49977c2f
commit a86a5f153a5e81a50912fba3a3eaa74a49977c2f
Author: Philipp Tomsich <philipp.tomsich@vrull.eu>
Date: Tue Apr 26 16:03:58 2022 +0200
RISC-V: Support immediates in XVentanaCondOps
When if-conversion encounters sequences using immediates, the
sequences can't trivially map back onto vt.maskc/vt.maskcn (even if
benefitial) due to vt.maskc and vt.maskcn not having immediate forms.
This adds a splitter to rewrite opportunities for XVentanaCondOps that
operate on an immediate by first putting the immediate into a register
to enable the non-immediate vt.maskc/vt.maskcn instructions to operate
on the value.
Consider code, such as
long func2 (long a, long c)
{
if (c)
a = 2;
else
a = 5;
return a;
}
which will be converted to
func2:
seqz a0,a2
neg a0,a0
andi a0,a0,3
addi a0,a0,2
ret
Following this change, we generate
li a0,3
vt.maskcn a0,a0,a2
addi a0,a0,2
ret
This commit also introduces a simple unit test for if-conversion with
immediate (literal) values as the sources for simple sets in the THEN
and ELSE blocks. The test checks that Ventana's conditional mask
instruction (vt.maskc<n>) is emitted as part of the resultant branchless
instruction sequence.
gcc/ChangeLog:
* config/riscv/xventanacondops.md: Support immediates for
vt.maskc/vt.maskcn through a splitter.
gcc/testsuite/ChangeLog:
* gcc.target/riscv/xventanacondops-ifconv-imm.c: New test.
Signed-off-by: Philipp Tomsich <philipp.tomsich@vrull.eu>
Reviewed-by: Henry Brausen <henry.brausen@vrull.eu>
Commit-notes:
Ref #204
END
Diff:
---
gcc/config/riscv/xventanacondops.md | 24 ++++++++++++++++++++--
.../gcc.target/riscv/xventanacondops-ifconv-imm.c | 19 +++++++++++++++++
2 files changed, 41 insertions(+), 2 deletions(-)
diff --git a/gcc/config/riscv/xventanacondops.md b/gcc/config/riscv/xventanacondops.md
index 1e01fe1c6de..5128813e1ea 100644
--- a/gcc/config/riscv/xventanacondops.md
+++ b/gcc/config/riscv/xventanacondops.md
@@ -29,6 +29,26 @@
"TARGET_XVENTANACONDOPS"
"vt.maskc<n>\t%0,%2,%1")
+;; XVentanaCondOps does not have immediate forms, so we need to do extra
+;; work to support these: if we encounter a vt.maskc/n with an immediate,
+;; we split this into a load-immediate followed by a vt.maskc/n.
+(define_split
+ [(set (match_operand:DI 0 "register_operand")
+ (and:DI (neg:DI (match_operator:DI 1 "equality_operator"
+ [(match_operand:DI 2 "register_operand")
+ (const_int 0)]))
+ (match_operand:DI 3 "immediate_operand")))
+ (clobber (match_operand:DI 4 "register_operand"))]
+ "TARGET_XVENTANACONDOPS"
+ [(set (match_dup 4) (match_dup 3))
+ (set (match_dup 0) (and:DI (neg:DI (match_dup 1))
+ (match_dup 4)))]
+{
+ /* Eliminate the clobber/temporary, if it is not needed. */
+ if (!rtx_equal_p (operands[0], operands[2]))
+ operands[4] = operands[0];
+})
+
;; Make order operators digestible to the vt.maskc<n> logic by
;; wrapping their result in a comparison against (const_int 0).
@@ -37,7 +57,7 @@
[(set (match_operand:X 0 "register_operand")
(and:X (neg:X (match_operator:X 1 "anyge_operator"
[(match_operand:X 2 "register_operand")
- (match_operand:X 3 "register_operand")]))
+ (match_operand:X 3 "arith_operand")]))
(match_operand:X 4 "register_operand")))
(clobber (match_operand:X 5 "register_operand"))]
"TARGET_XVENTANACONDOPS"
@@ -54,7 +74,7 @@
[(set (match_operand:X 0 "register_operand")
(and:X (neg:X (match_operator:X 1 "anygt_operator"
[(match_operand:X 2 "register_operand")
- (match_operand:X 3 "register_operand")]))
+ (match_operand:X 3 "arith_operand")]))
(match_operand:X 4 "register_operand")))
(clobber (match_operand:X 5 "register_operand"))]
"TARGET_XVENTANACONDOPS"
diff --git a/gcc/testsuite/gcc.target/riscv/xventanacondops-ifconv-imm.c b/gcc/testsuite/gcc.target/riscv/xventanacondops-ifconv-imm.c
new file mode 100644
index 00000000000..0012e7b669c
--- /dev/null
+++ b/gcc/testsuite/gcc.target/riscv/xventanacondops-ifconv-imm.c
@@ -0,0 +1,19 @@
+/* { dg-do compile } */
+/* { dg-options "-march=rv64gc_xventanacondops -mabi=lp64" } */
+/* { dg-skip-if "" { *-*-* } { "-O0" "-Og" "-Os" "-Oz" } } */
+
+/* Each function below should emit a vt.maskcn instruction */
+
+long
+foo0 (long a, long b, long c)
+{
+ if (c)
+ a = 0;
+ else
+ a = 5;
+ return a;
+}
+
+/* { dg-final { scan-assembler-times "vt.maskcn\t" 1 } } */
+/* { dg-final { scan-assembler-not "beqz\t" } } */
+/* { dg-final { scan-assembler-not "bnez\t" } } */
^ permalink raw reply [flat|nested] 7+ messages in thread
* [gcc(refs/vendors/vrull/heads/for-upstream)] RISC-V: Support immediates in XVentanaCondOps
@ 2022-12-01 13:23 Philipp Tomsich
0 siblings, 0 replies; 7+ messages in thread
From: Philipp Tomsich @ 2022-12-01 13:23 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:1b99fc33fd29c0b056f02dd78dd120ef7c8d1822
commit 1b99fc33fd29c0b056f02dd78dd120ef7c8d1822
Author: Philipp Tomsich <philipp.tomsich@vrull.eu>
Date: Tue Apr 26 16:03:58 2022 +0200
RISC-V: Support immediates in XVentanaCondOps
When if-conversion encounters sequences using immediates, the
sequences can't trivially map back onto vt.maskc/vt.maskcn (even if
benefitial) due to vt.maskc and vt.maskcn not having immediate forms.
This adds a splitter to rewrite opportunities for XVentanaCondOps that
operate on an immediate by first putting the immediate into a register
to enable the non-immediate vt.maskc/vt.maskcn instructions to operate
on the value.
Consider code, such as
long func2 (long a, long c)
{
if (c)
a = 2;
else
a = 5;
return a;
}
which will be converted to
func2:
seqz a0,a2
neg a0,a0
andi a0,a0,3
addi a0,a0,2
ret
Following this change, we generate
li a0,3
vt.maskcn a0,a0,a2
addi a0,a0,2
ret
This commit also introduces a simple unit test for if-conversion with
immediate (literal) values as the sources for simple sets in the THEN
and ELSE blocks. The test checks that Ventana's conditional mask
instruction (vt.maskc<n>) is emitted as part of the resultant branchless
instruction sequence.
gcc/ChangeLog:
* config/riscv/xventanacondops.md: Support immediates for
vt.maskc/vt.maskcn through a splitter.
gcc/testsuite/ChangeLog:
* gcc.target/riscv/xventanacondops-ifconv-imm.c: New test.
Signed-off-by: Philipp Tomsich <philipp.tomsich@vrull.eu>
Reviewed-by: Henry Brausen <henry.brausen@vrull.eu>
Commit-notes:
Ref #204
END
Diff:
---
gcc/config/riscv/xventanacondops.md | 24 ++++++++++++++++++++--
.../gcc.target/riscv/xventanacondops-ifconv-imm.c | 19 +++++++++++++++++
2 files changed, 41 insertions(+), 2 deletions(-)
diff --git a/gcc/config/riscv/xventanacondops.md b/gcc/config/riscv/xventanacondops.md
index 1e01fe1c6de..5128813e1ea 100644
--- a/gcc/config/riscv/xventanacondops.md
+++ b/gcc/config/riscv/xventanacondops.md
@@ -29,6 +29,26 @@
"TARGET_XVENTANACONDOPS"
"vt.maskc<n>\t%0,%2,%1")
+;; XVentanaCondOps does not have immediate forms, so we need to do extra
+;; work to support these: if we encounter a vt.maskc/n with an immediate,
+;; we split this into a load-immediate followed by a vt.maskc/n.
+(define_split
+ [(set (match_operand:DI 0 "register_operand")
+ (and:DI (neg:DI (match_operator:DI 1 "equality_operator"
+ [(match_operand:DI 2 "register_operand")
+ (const_int 0)]))
+ (match_operand:DI 3 "immediate_operand")))
+ (clobber (match_operand:DI 4 "register_operand"))]
+ "TARGET_XVENTANACONDOPS"
+ [(set (match_dup 4) (match_dup 3))
+ (set (match_dup 0) (and:DI (neg:DI (match_dup 1))
+ (match_dup 4)))]
+{
+ /* Eliminate the clobber/temporary, if it is not needed. */
+ if (!rtx_equal_p (operands[0], operands[2]))
+ operands[4] = operands[0];
+})
+
;; Make order operators digestible to the vt.maskc<n> logic by
;; wrapping their result in a comparison against (const_int 0).
@@ -37,7 +57,7 @@
[(set (match_operand:X 0 "register_operand")
(and:X (neg:X (match_operator:X 1 "anyge_operator"
[(match_operand:X 2 "register_operand")
- (match_operand:X 3 "register_operand")]))
+ (match_operand:X 3 "arith_operand")]))
(match_operand:X 4 "register_operand")))
(clobber (match_operand:X 5 "register_operand"))]
"TARGET_XVENTANACONDOPS"
@@ -54,7 +74,7 @@
[(set (match_operand:X 0 "register_operand")
(and:X (neg:X (match_operator:X 1 "anygt_operator"
[(match_operand:X 2 "register_operand")
- (match_operand:X 3 "register_operand")]))
+ (match_operand:X 3 "arith_operand")]))
(match_operand:X 4 "register_operand")))
(clobber (match_operand:X 5 "register_operand"))]
"TARGET_XVENTANACONDOPS"
diff --git a/gcc/testsuite/gcc.target/riscv/xventanacondops-ifconv-imm.c b/gcc/testsuite/gcc.target/riscv/xventanacondops-ifconv-imm.c
new file mode 100644
index 00000000000..0012e7b669c
--- /dev/null
+++ b/gcc/testsuite/gcc.target/riscv/xventanacondops-ifconv-imm.c
@@ -0,0 +1,19 @@
+/* { dg-do compile } */
+/* { dg-options "-march=rv64gc_xventanacondops -mabi=lp64" } */
+/* { dg-skip-if "" { *-*-* } { "-O0" "-Og" "-Os" "-Oz" } } */
+
+/* Each function below should emit a vt.maskcn instruction */
+
+long
+foo0 (long a, long b, long c)
+{
+ if (c)
+ a = 0;
+ else
+ a = 5;
+ return a;
+}
+
+/* { dg-final { scan-assembler-times "vt.maskcn\t" 1 } } */
+/* { dg-final { scan-assembler-not "beqz\t" } } */
+/* { dg-final { scan-assembler-not "bnez\t" } } */
^ permalink raw reply [flat|nested] 7+ messages in thread
* [gcc(refs/vendors/vrull/heads/for-upstream)] RISC-V: Support immediates in XVentanaCondOps
@ 2022-11-18 20:26 Philipp Tomsich
0 siblings, 0 replies; 7+ messages in thread
From: Philipp Tomsich @ 2022-11-18 20:26 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:71b468d685c8aa8f46d793181c8e5a22586331a0
commit 71b468d685c8aa8f46d793181c8e5a22586331a0
Author: Philipp Tomsich <philipp.tomsich@vrull.eu>
Date: Tue Apr 26 16:03:58 2022 +0200
RISC-V: Support immediates in XVentanaCondOps
When if-conversion encounters sequences using immediates, the
sequences can't trivially map back onto vt.maskc/vt.maskcn (even if
benefitial) due to vt.maskc and vt.maskcn not having immediate forms.
This adds a splitter to rewrite opportunities for XVentanaCondOps that
operate on an immediate by first putting the immediate into a register
to enable the non-immediate vt.maskc/vt.maskcn instructions to operate
on the value.
Consider code, such as
long func2 (long a, long c)
{
if (c)
a = 2;
else
a = 5;
return a;
}
which will be converted to
func2:
seqz a0,a2
neg a0,a0
andi a0,a0,3
addi a0,a0,2
ret
Following this change, we generate
li a0,3
vt.maskcn a0,a0,a2
addi a0,a0,2
ret
This commit also introduces a simple unit test for if-conversion with
immediate (literal) values as the sources for simple sets in the THEN
and ELSE blocks. The test checks that Ventana's conditional mask
instruction (vt.maskc<n>) is emitted as part of the resultant branchless
instruction sequence.
gcc/ChangeLog:
* config/riscv/xventanacondops.md: Support immediates for
vt.maskc/vt.maskcn through a splitter.
gcc/testsuite/ChangeLog:
* gcc.target/riscv/xventanacondops-ifconv-imm.c: New test.
Signed-off-by: Philipp Tomsich <philipp.tomsich@vrull.eu>
Reviewed-by: Henry Brausen <henry.brausen@vrull.eu>
Commit-notes:
Ref #204
END
Diff:
---
gcc/config/riscv/xventanacondops.md | 24 ++++++++++++++++++++--
.../gcc.target/riscv/xventanacondops-ifconv-imm.c | 19 +++++++++++++++++
2 files changed, 41 insertions(+), 2 deletions(-)
diff --git a/gcc/config/riscv/xventanacondops.md b/gcc/config/riscv/xventanacondops.md
index 1e01fe1c6de..5128813e1ea 100644
--- a/gcc/config/riscv/xventanacondops.md
+++ b/gcc/config/riscv/xventanacondops.md
@@ -29,6 +29,26 @@
"TARGET_XVENTANACONDOPS"
"vt.maskc<n>\t%0,%2,%1")
+;; XVentanaCondOps does not have immediate forms, so we need to do extra
+;; work to support these: if we encounter a vt.maskc/n with an immediate,
+;; we split this into a load-immediate followed by a vt.maskc/n.
+(define_split
+ [(set (match_operand:DI 0 "register_operand")
+ (and:DI (neg:DI (match_operator:DI 1 "equality_operator"
+ [(match_operand:DI 2 "register_operand")
+ (const_int 0)]))
+ (match_operand:DI 3 "immediate_operand")))
+ (clobber (match_operand:DI 4 "register_operand"))]
+ "TARGET_XVENTANACONDOPS"
+ [(set (match_dup 4) (match_dup 3))
+ (set (match_dup 0) (and:DI (neg:DI (match_dup 1))
+ (match_dup 4)))]
+{
+ /* Eliminate the clobber/temporary, if it is not needed. */
+ if (!rtx_equal_p (operands[0], operands[2]))
+ operands[4] = operands[0];
+})
+
;; Make order operators digestible to the vt.maskc<n> logic by
;; wrapping their result in a comparison against (const_int 0).
@@ -37,7 +57,7 @@
[(set (match_operand:X 0 "register_operand")
(and:X (neg:X (match_operator:X 1 "anyge_operator"
[(match_operand:X 2 "register_operand")
- (match_operand:X 3 "register_operand")]))
+ (match_operand:X 3 "arith_operand")]))
(match_operand:X 4 "register_operand")))
(clobber (match_operand:X 5 "register_operand"))]
"TARGET_XVENTANACONDOPS"
@@ -54,7 +74,7 @@
[(set (match_operand:X 0 "register_operand")
(and:X (neg:X (match_operator:X 1 "anygt_operator"
[(match_operand:X 2 "register_operand")
- (match_operand:X 3 "register_operand")]))
+ (match_operand:X 3 "arith_operand")]))
(match_operand:X 4 "register_operand")))
(clobber (match_operand:X 5 "register_operand"))]
"TARGET_XVENTANACONDOPS"
diff --git a/gcc/testsuite/gcc.target/riscv/xventanacondops-ifconv-imm.c b/gcc/testsuite/gcc.target/riscv/xventanacondops-ifconv-imm.c
new file mode 100644
index 00000000000..0012e7b669c
--- /dev/null
+++ b/gcc/testsuite/gcc.target/riscv/xventanacondops-ifconv-imm.c
@@ -0,0 +1,19 @@
+/* { dg-do compile } */
+/* { dg-options "-march=rv64gc_xventanacondops -mabi=lp64" } */
+/* { dg-skip-if "" { *-*-* } { "-O0" "-Og" "-Os" "-Oz" } } */
+
+/* Each function below should emit a vt.maskcn instruction */
+
+long
+foo0 (long a, long b, long c)
+{
+ if (c)
+ a = 0;
+ else
+ a = 5;
+ return a;
+}
+
+/* { dg-final { scan-assembler-times "vt.maskcn\t" 1 } } */
+/* { dg-final { scan-assembler-not "beqz\t" } } */
+/* { dg-final { scan-assembler-not "bnez\t" } } */
^ permalink raw reply [flat|nested] 7+ messages in thread
* [gcc(refs/vendors/vrull/heads/for-upstream)] RISC-V: Support immediates in XVentanaCondOps
@ 2022-11-18 20:23 Philipp Tomsich
0 siblings, 0 replies; 7+ messages in thread
From: Philipp Tomsich @ 2022-11-18 20:23 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:f2f4cda943d0346b12598da48b1d0b87f673e5b3
commit f2f4cda943d0346b12598da48b1d0b87f673e5b3
Author: Philipp Tomsich <philipp.tomsich@vrull.eu>
Date: Tue Apr 26 16:03:58 2022 +0200
RISC-V: Support immediates in XVentanaCondOps
When if-conversion encounters sequences using immediates, the
sequences can't trivially map back onto vt.maskc/vt.maskcn (even if
benefitial) due to vt.maskc and vt.maskcn not having immediate forms.
This adds a splitter to rewrite opportunities for XVentanaCondOps that
operate on an immediate by first putting the immediate into a register
to enable the non-immediate vt.maskc/vt.maskcn instructions to operate
on the value.
Consider code, such as
long func2 (long a, long c)
{
if (c)
a = 2;
else
a = 5;
return a;
}
which will be converted to
func2:
seqz a0,a2
neg a0,a0
andi a0,a0,3
addi a0,a0,2
ret
Following this change, we generate
li a0,3
vt.maskcn a0,a0,a2
addi a0,a0,2
ret
This commit also introduces a simple unit test for if-conversion with
immediate (literal) values as the sources for simple sets in the THEN
and ELSE blocks. The test checks that Ventana's conditional mask
instruction (vt.maskc<n>) is emitted as part of the resultant branchless
instruction sequence.
gcc/ChangeLog:
* config/riscv/xventanacondops.md: Support immediates for
vt.maskc/vt.maskcn through a splitter.
gcc/testsuite/ChangeLog:
* gcc.target/riscv/xventanacondops-ifconv-imm.c: New test.
Signed-off-by: Philipp Tomsich <philipp.tomsich@vrull.eu>
Reviewed-by: Henry Brausen <henry.brausen@vrull.eu>
Commit-notes:
Ref #204
END
Diff:
---
gcc/config/riscv/xventanacondops.md | 24 ++++++++++++++++++++--
.../gcc.target/riscv/xventanacondops-ifconv-imm.c | 19 +++++++++++++++++
2 files changed, 41 insertions(+), 2 deletions(-)
diff --git a/gcc/config/riscv/xventanacondops.md b/gcc/config/riscv/xventanacondops.md
index 1e01fe1c6de..5128813e1ea 100644
--- a/gcc/config/riscv/xventanacondops.md
+++ b/gcc/config/riscv/xventanacondops.md
@@ -29,6 +29,26 @@
"TARGET_XVENTANACONDOPS"
"vt.maskc<n>\t%0,%2,%1")
+;; XVentanaCondOps does not have immediate forms, so we need to do extra
+;; work to support these: if we encounter a vt.maskc/n with an immediate,
+;; we split this into a load-immediate followed by a vt.maskc/n.
+(define_split
+ [(set (match_operand:DI 0 "register_operand")
+ (and:DI (neg:DI (match_operator:DI 1 "equality_operator"
+ [(match_operand:DI 2 "register_operand")
+ (const_int 0)]))
+ (match_operand:DI 3 "immediate_operand")))
+ (clobber (match_operand:DI 4 "register_operand"))]
+ "TARGET_XVENTANACONDOPS"
+ [(set (match_dup 4) (match_dup 3))
+ (set (match_dup 0) (and:DI (neg:DI (match_dup 1))
+ (match_dup 4)))]
+{
+ /* Eliminate the clobber/temporary, if it is not needed. */
+ if (!rtx_equal_p (operands[0], operands[2]))
+ operands[4] = operands[0];
+})
+
;; Make order operators digestible to the vt.maskc<n> logic by
;; wrapping their result in a comparison against (const_int 0).
@@ -37,7 +57,7 @@
[(set (match_operand:X 0 "register_operand")
(and:X (neg:X (match_operator:X 1 "anyge_operator"
[(match_operand:X 2 "register_operand")
- (match_operand:X 3 "register_operand")]))
+ (match_operand:X 3 "arith_operand")]))
(match_operand:X 4 "register_operand")))
(clobber (match_operand:X 5 "register_operand"))]
"TARGET_XVENTANACONDOPS"
@@ -54,7 +74,7 @@
[(set (match_operand:X 0 "register_operand")
(and:X (neg:X (match_operator:X 1 "anygt_operator"
[(match_operand:X 2 "register_operand")
- (match_operand:X 3 "register_operand")]))
+ (match_operand:X 3 "arith_operand")]))
(match_operand:X 4 "register_operand")))
(clobber (match_operand:X 5 "register_operand"))]
"TARGET_XVENTANACONDOPS"
diff --git a/gcc/testsuite/gcc.target/riscv/xventanacondops-ifconv-imm.c b/gcc/testsuite/gcc.target/riscv/xventanacondops-ifconv-imm.c
new file mode 100644
index 00000000000..0012e7b669c
--- /dev/null
+++ b/gcc/testsuite/gcc.target/riscv/xventanacondops-ifconv-imm.c
@@ -0,0 +1,19 @@
+/* { dg-do compile } */
+/* { dg-options "-march=rv64gc_xventanacondops -mabi=lp64" } */
+/* { dg-skip-if "" { *-*-* } { "-O0" "-Og" "-Os" "-Oz" } } */
+
+/* Each function below should emit a vt.maskcn instruction */
+
+long
+foo0 (long a, long b, long c)
+{
+ if (c)
+ a = 0;
+ else
+ a = 5;
+ return a;
+}
+
+/* { dg-final { scan-assembler-times "vt.maskcn\t" 1 } } */
+/* { dg-final { scan-assembler-not "beqz\t" } } */
+/* { dg-final { scan-assembler-not "bnez\t" } } */
^ permalink raw reply [flat|nested] 7+ messages in thread
* [gcc(refs/vendors/vrull/heads/for-upstream)] RISC-V: Support immediates in XVentanaCondOps
@ 2022-11-18 11:35 Philipp Tomsich
0 siblings, 0 replies; 7+ messages in thread
From: Philipp Tomsich @ 2022-11-18 11:35 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:4d26578b789ae647637bd079bf27ceeb1e512c34
commit 4d26578b789ae647637bd079bf27ceeb1e512c34
Author: Philipp Tomsich <philipp.tomsich@vrull.eu>
Date: Tue Apr 26 16:03:58 2022 +0200
RISC-V: Support immediates in XVentanaCondOps
When if-conversion encounters sequences using immediates, the
sequences can't trivially map back onto vt.maskc/vt.maskcn (even if
benefitial) due to vt.maskc and vt.maskcn not having immediate forms.
This adds a splitter to rewrite opportunities for XVentanaCondOps that
operate on an immediate by first putting the immediate into a register
to enable the non-immediate vt.maskc/vt.maskcn instructions to operate
on the value.
Consider code, such as
long func2 (long a, long c)
{
if (c)
a = 2;
else
a = 5;
return a;
}
which will be converted to
func2:
seqz a0,a2
neg a0,a0
andi a0,a0,3
addi a0,a0,2
ret
Following this change, we generate
li a0,3
vt.maskcn a0,a0,a2
addi a0,a0,2
ret
This commit also introduces a simple unit test for if-conversion with
immediate (literal) values as the sources for simple sets in the THEN
and ELSE blocks. The test checks that Ventana's conditional mask
instruction (vt.maskc<n>) is emitted as part of the resultant branchless
instruction sequence.
gcc/ChangeLog:
* config/riscv/xventanacondops.md: Support immediates for
vt.maskc/vt.maskcn through a splitter.
gcc/testsuite/ChangeLog:
* gcc.target/riscv/xventanacondops-ifconv-imm.c: New test.
Signed-off-by: Philipp Tomsich <philipp.tomsich@vrull.eu>
Reviewed-by: Henry Brausen <henry.brausen@vrull.eu>
Commit-notes:
Ref #204
END
Diff:
---
gcc/config/riscv/xventanacondops.md | 24 ++++++++++++++++++++--
.../gcc.target/riscv/xventanacondops-ifconv-imm.c | 19 +++++++++++++++++
2 files changed, 41 insertions(+), 2 deletions(-)
diff --git a/gcc/config/riscv/xventanacondops.md b/gcc/config/riscv/xventanacondops.md
index 1e01fe1c6de..5128813e1ea 100644
--- a/gcc/config/riscv/xventanacondops.md
+++ b/gcc/config/riscv/xventanacondops.md
@@ -29,6 +29,26 @@
"TARGET_XVENTANACONDOPS"
"vt.maskc<n>\t%0,%2,%1")
+;; XVentanaCondOps does not have immediate forms, so we need to do extra
+;; work to support these: if we encounter a vt.maskc/n with an immediate,
+;; we split this into a load-immediate followed by a vt.maskc/n.
+(define_split
+ [(set (match_operand:DI 0 "register_operand")
+ (and:DI (neg:DI (match_operator:DI 1 "equality_operator"
+ [(match_operand:DI 2 "register_operand")
+ (const_int 0)]))
+ (match_operand:DI 3 "immediate_operand")))
+ (clobber (match_operand:DI 4 "register_operand"))]
+ "TARGET_XVENTANACONDOPS"
+ [(set (match_dup 4) (match_dup 3))
+ (set (match_dup 0) (and:DI (neg:DI (match_dup 1))
+ (match_dup 4)))]
+{
+ /* Eliminate the clobber/temporary, if it is not needed. */
+ if (!rtx_equal_p (operands[0], operands[2]))
+ operands[4] = operands[0];
+})
+
;; Make order operators digestible to the vt.maskc<n> logic by
;; wrapping their result in a comparison against (const_int 0).
@@ -37,7 +57,7 @@
[(set (match_operand:X 0 "register_operand")
(and:X (neg:X (match_operator:X 1 "anyge_operator"
[(match_operand:X 2 "register_operand")
- (match_operand:X 3 "register_operand")]))
+ (match_operand:X 3 "arith_operand")]))
(match_operand:X 4 "register_operand")))
(clobber (match_operand:X 5 "register_operand"))]
"TARGET_XVENTANACONDOPS"
@@ -54,7 +74,7 @@
[(set (match_operand:X 0 "register_operand")
(and:X (neg:X (match_operator:X 1 "anygt_operator"
[(match_operand:X 2 "register_operand")
- (match_operand:X 3 "register_operand")]))
+ (match_operand:X 3 "arith_operand")]))
(match_operand:X 4 "register_operand")))
(clobber (match_operand:X 5 "register_operand"))]
"TARGET_XVENTANACONDOPS"
diff --git a/gcc/testsuite/gcc.target/riscv/xventanacondops-ifconv-imm.c b/gcc/testsuite/gcc.target/riscv/xventanacondops-ifconv-imm.c
new file mode 100644
index 00000000000..0012e7b669c
--- /dev/null
+++ b/gcc/testsuite/gcc.target/riscv/xventanacondops-ifconv-imm.c
@@ -0,0 +1,19 @@
+/* { dg-do compile } */
+/* { dg-options "-march=rv64gc_xventanacondops -mabi=lp64" } */
+/* { dg-skip-if "" { *-*-* } { "-O0" "-Og" "-Os" "-Oz" } } */
+
+/* Each function below should emit a vt.maskcn instruction */
+
+long
+foo0 (long a, long b, long c)
+{
+ if (c)
+ a = 0;
+ else
+ a = 5;
+ return a;
+}
+
+/* { dg-final { scan-assembler-times "vt.maskcn\t" 1 } } */
+/* { dg-final { scan-assembler-not "beqz\t" } } */
+/* { dg-final { scan-assembler-not "bnez\t" } } */
^ permalink raw reply [flat|nested] 7+ messages in thread
* [gcc(refs/vendors/vrull/heads/for-upstream)] RISC-V: Support immediates in XVentanaCondOps
@ 2022-11-17 22:26 Philipp Tomsich
0 siblings, 0 replies; 7+ messages in thread
From: Philipp Tomsich @ 2022-11-17 22:26 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:ccbf6d5efde8ab6eb5296b9b2056d78b332086de
commit ccbf6d5efde8ab6eb5296b9b2056d78b332086de
Author: Philipp Tomsich <philipp.tomsich@vrull.eu>
Date: Tue Apr 26 16:03:58 2022 +0200
RISC-V: Support immediates in XVentanaCondOps
When if-conversion encounters sequences using immediates, the
sequences can't trivially map back onto vt.maskc/vt.maskcn (even if
benefitial) due to vt.maskc and vt.maskcn not having immediate forms.
This adds a splitter to rewrite opportunities for XVentanaCondOps that
operate on an immediate by first putting the immediate into a register
to enable the non-immediate vt.maskc/vt.maskcn instructions to operate
on the value.
Consider code, such as
long func2 (long a, long c)
{
if (c)
a = 2;
else
a = 5;
return a;
}
which will be converted to
func2:
seqz a0,a2
neg a0,a0
andi a0,a0,3
addi a0,a0,2
ret
Following this change, we generate
li a0,3
vt.maskcn a0,a0,a2
addi a0,a0,2
ret
This commit also introduces a simple unit test for if-conversion with
immediate (literal) values as the sources for simple sets in the THEN
and ELSE blocks. The test checks that Ventana's conditional mask
instruction (vt.maskc<n>) is emitted as part of the resultant branchless
instruction sequence.
gcc/ChangeLog:
* config/riscv/xventanacondops.md: Support immediates for
vt.maskc/vt.maskcn through a splitter.
gcc/testsuite/ChangeLog:
* gcc.target/riscv/xventanacondops-ifconv-imm.c: New test.
Signed-off-by: Philipp Tomsich <philipp.tomsich@vrull.eu>
Reviewed-by: Henry Brausen <henry.brausen@vrull.eu>
Commit-notes:
Ref #204
END
Diff:
---
gcc/config/riscv/xventanacondops.md | 24 ++++++++++++++++++++--
.../gcc.target/riscv/xventanacondops-ifconv-imm.c | 19 +++++++++++++++++
2 files changed, 41 insertions(+), 2 deletions(-)
diff --git a/gcc/config/riscv/xventanacondops.md b/gcc/config/riscv/xventanacondops.md
index 1e01fe1c6de..5128813e1ea 100644
--- a/gcc/config/riscv/xventanacondops.md
+++ b/gcc/config/riscv/xventanacondops.md
@@ -29,6 +29,26 @@
"TARGET_XVENTANACONDOPS"
"vt.maskc<n>\t%0,%2,%1")
+;; XVentanaCondOps does not have immediate forms, so we need to do extra
+;; work to support these: if we encounter a vt.maskc/n with an immediate,
+;; we split this into a load-immediate followed by a vt.maskc/n.
+(define_split
+ [(set (match_operand:DI 0 "register_operand")
+ (and:DI (neg:DI (match_operator:DI 1 "equality_operator"
+ [(match_operand:DI 2 "register_operand")
+ (const_int 0)]))
+ (match_operand:DI 3 "immediate_operand")))
+ (clobber (match_operand:DI 4 "register_operand"))]
+ "TARGET_XVENTANACONDOPS"
+ [(set (match_dup 4) (match_dup 3))
+ (set (match_dup 0) (and:DI (neg:DI (match_dup 1))
+ (match_dup 4)))]
+{
+ /* Eliminate the clobber/temporary, if it is not needed. */
+ if (!rtx_equal_p (operands[0], operands[2]))
+ operands[4] = operands[0];
+})
+
;; Make order operators digestible to the vt.maskc<n> logic by
;; wrapping their result in a comparison against (const_int 0).
@@ -37,7 +57,7 @@
[(set (match_operand:X 0 "register_operand")
(and:X (neg:X (match_operator:X 1 "anyge_operator"
[(match_operand:X 2 "register_operand")
- (match_operand:X 3 "register_operand")]))
+ (match_operand:X 3 "arith_operand")]))
(match_operand:X 4 "register_operand")))
(clobber (match_operand:X 5 "register_operand"))]
"TARGET_XVENTANACONDOPS"
@@ -54,7 +74,7 @@
[(set (match_operand:X 0 "register_operand")
(and:X (neg:X (match_operator:X 1 "anygt_operator"
[(match_operand:X 2 "register_operand")
- (match_operand:X 3 "register_operand")]))
+ (match_operand:X 3 "arith_operand")]))
(match_operand:X 4 "register_operand")))
(clobber (match_operand:X 5 "register_operand"))]
"TARGET_XVENTANACONDOPS"
diff --git a/gcc/testsuite/gcc.target/riscv/xventanacondops-ifconv-imm.c b/gcc/testsuite/gcc.target/riscv/xventanacondops-ifconv-imm.c
new file mode 100644
index 00000000000..0012e7b669c
--- /dev/null
+++ b/gcc/testsuite/gcc.target/riscv/xventanacondops-ifconv-imm.c
@@ -0,0 +1,19 @@
+/* { dg-do compile } */
+/* { dg-options "-march=rv64gc_xventanacondops -mabi=lp64" } */
+/* { dg-skip-if "" { *-*-* } { "-O0" "-Og" "-Os" "-Oz" } } */
+
+/* Each function below should emit a vt.maskcn instruction */
+
+long
+foo0 (long a, long b, long c)
+{
+ if (c)
+ a = 0;
+ else
+ a = 5;
+ return a;
+}
+
+/* { dg-final { scan-assembler-times "vt.maskcn\t" 1 } } */
+/* { dg-final { scan-assembler-not "beqz\t" } } */
+/* { dg-final { scan-assembler-not "bnez\t" } } */
^ permalink raw reply [flat|nested] 7+ messages in thread
* [gcc(refs/vendors/vrull/heads/for-upstream)] RISC-V: Support immediates in XVentanaCondOps
@ 2022-11-15 15:00 Philipp Tomsich
0 siblings, 0 replies; 7+ messages in thread
From: Philipp Tomsich @ 2022-11-15 15:00 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:eb948184321c799fc1cd451e43de17960fbd1f55
commit eb948184321c799fc1cd451e43de17960fbd1f55
Author: Philipp Tomsich <philipp.tomsich@vrull.eu>
Date: Tue Apr 26 16:03:58 2022 +0200
RISC-V: Support immediates in XVentanaCondOps
When if-conversion encounters sequences using immediates, the
sequences can't trivially map back onto vt.maskc/vt.maskcn (even if
benefitial) due to vt.maskc and vt.maskcn not having immediate forms.
This adds a splitter to rewrite opportunities for XVentanaCondOps that
operate on an immediate by first putting the immediate into a register
to enable the non-immediate vt.maskc/vt.maskcn instructions to operate
on the value.
Consider code, such as
long func2 (long a, long c)
{
if (c)
a = 2;
else
a = 5;
return a;
}
which will be converted to
func2:
seqz a0,a2
neg a0,a0
andi a0,a0,3
addi a0,a0,2
ret
Following this change, we generate
li a0,3
vt.maskcn a0,a0,a2
addi a0,a0,2
ret
This commit also introduces a simple unit test for if-conversion with
immediate (literal) values as the sources for simple sets in the THEN
and ELSE blocks. The test checks that Ventana's conditional mask
instruction (vt.maskc<n>) is emitted as part of the resultant branchless
instruction sequence.
gcc/ChangeLog:
* config/riscv/xventanacondops.md: Support immediates for
vt.maskc/vt.maskcn through a splitter.
gcc/testsuite/ChangeLog:
* gcc.target/riscv/xventanacondops-ifconv-imm.c: New test.
Signed-off-by: Philipp Tomsich <philipp.tomsich@vrull.eu>
Reviewed-by: Henry Brausen <henry.brausen@vrull.eu>
Commit-notes:
Ref #204
END
Diff:
---
gcc/config/riscv/xventanacondops.md | 24 ++++++++++++++++++++--
.../gcc.target/riscv/xventanacondops-ifconv-imm.c | 19 +++++++++++++++++
2 files changed, 41 insertions(+), 2 deletions(-)
diff --git a/gcc/config/riscv/xventanacondops.md b/gcc/config/riscv/xventanacondops.md
index 1e01fe1c6de9..5128813e1ea3 100644
--- a/gcc/config/riscv/xventanacondops.md
+++ b/gcc/config/riscv/xventanacondops.md
@@ -29,6 +29,26 @@
"TARGET_XVENTANACONDOPS"
"vt.maskc<n>\t%0,%2,%1")
+;; XVentanaCondOps does not have immediate forms, so we need to do extra
+;; work to support these: if we encounter a vt.maskc/n with an immediate,
+;; we split this into a load-immediate followed by a vt.maskc/n.
+(define_split
+ [(set (match_operand:DI 0 "register_operand")
+ (and:DI (neg:DI (match_operator:DI 1 "equality_operator"
+ [(match_operand:DI 2 "register_operand")
+ (const_int 0)]))
+ (match_operand:DI 3 "immediate_operand")))
+ (clobber (match_operand:DI 4 "register_operand"))]
+ "TARGET_XVENTANACONDOPS"
+ [(set (match_dup 4) (match_dup 3))
+ (set (match_dup 0) (and:DI (neg:DI (match_dup 1))
+ (match_dup 4)))]
+{
+ /* Eliminate the clobber/temporary, if it is not needed. */
+ if (!rtx_equal_p (operands[0], operands[2]))
+ operands[4] = operands[0];
+})
+
;; Make order operators digestible to the vt.maskc<n> logic by
;; wrapping their result in a comparison against (const_int 0).
@@ -37,7 +57,7 @@
[(set (match_operand:X 0 "register_operand")
(and:X (neg:X (match_operator:X 1 "anyge_operator"
[(match_operand:X 2 "register_operand")
- (match_operand:X 3 "register_operand")]))
+ (match_operand:X 3 "arith_operand")]))
(match_operand:X 4 "register_operand")))
(clobber (match_operand:X 5 "register_operand"))]
"TARGET_XVENTANACONDOPS"
@@ -54,7 +74,7 @@
[(set (match_operand:X 0 "register_operand")
(and:X (neg:X (match_operator:X 1 "anygt_operator"
[(match_operand:X 2 "register_operand")
- (match_operand:X 3 "register_operand")]))
+ (match_operand:X 3 "arith_operand")]))
(match_operand:X 4 "register_operand")))
(clobber (match_operand:X 5 "register_operand"))]
"TARGET_XVENTANACONDOPS"
diff --git a/gcc/testsuite/gcc.target/riscv/xventanacondops-ifconv-imm.c b/gcc/testsuite/gcc.target/riscv/xventanacondops-ifconv-imm.c
new file mode 100644
index 000000000000..0012e7b669c4
--- /dev/null
+++ b/gcc/testsuite/gcc.target/riscv/xventanacondops-ifconv-imm.c
@@ -0,0 +1,19 @@
+/* { dg-do compile } */
+/* { dg-options "-march=rv64gc_xventanacondops -mabi=lp64" } */
+/* { dg-skip-if "" { *-*-* } { "-O0" "-Og" "-Os" "-Oz" } } */
+
+/* Each function below should emit a vt.maskcn instruction */
+
+long
+foo0 (long a, long b, long c)
+{
+ if (c)
+ a = 0;
+ else
+ a = 5;
+ return a;
+}
+
+/* { dg-final { scan-assembler-times "vt.maskcn\t" 1 } } */
+/* { dg-final { scan-assembler-not "beqz\t" } } */
+/* { dg-final { scan-assembler-not "bnez\t" } } */
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-12-01 13:23 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-15 14:02 [gcc(refs/vendors/vrull/heads/for-upstream)] RISC-V: Support immediates in XVentanaCondOps Philipp Tomsich
2022-11-15 15:00 Philipp Tomsich
2022-11-17 22:26 Philipp Tomsich
2022-11-18 11:35 Philipp Tomsich
2022-11-18 20:23 Philipp Tomsich
2022-11-18 20:26 Philipp Tomsich
2022-12-01 13:23 Philipp Tomsich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).