public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-6305] Fix memory leak in PTA
@ 2023-02-23 14:57 Richard Biener
  0 siblings, 0 replies; only message in thread
From: Richard Biener @ 2023-02-23 14:57 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:426b0ae103894d1f1bd82e5f049ff8a53bd82a8d

commit r13-6305-g426b0ae103894d1f1bd82e5f049ff8a53bd82a8d
Author: Richard Biener <rguenther@suse.de>
Date:   Thu Feb 23 14:09:04 2023 +0100

    Fix memory leak in PTA
    
    When handle_lhs_call calls .create on the passed in vector it leaks
    any previous allocated storage.  Avoid doing that and instead rely
    on the caller for memory management, just truncate the vector.
    
            * tree-ssa-structalias.cc (handle_lhs_call): Do not
            re-create rhsc, only truncate it.

Diff:
---
 gcc/tree-ssa-structalias.cc | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gcc/tree-ssa-structalias.cc b/gcc/tree-ssa-structalias.cc
index 2ed32de06ed..07e0fd6827a 100644
--- a/gcc/tree-ssa-structalias.cc
+++ b/gcc/tree-ssa-structalias.cc
@@ -4408,17 +4408,17 @@ handle_lhs_call (gcall *stmt, tree lhs, int flags, vec<ce_s> &rhsc,
       && (flags & ERF_RETURN_ARG_MASK) < gimple_call_num_args (stmt))
     {
       tree arg;
-      rhsc.create (0);
+      rhsc.truncate (0);
       arg = gimple_call_arg (stmt, flags & ERF_RETURN_ARG_MASK);
       get_constraint_for (arg, &rhsc);
       process_all_all_constraints (lhsc, rhsc);
-      rhsc.release ();
+      rhsc.truncate (0);
     }
   else if (flags & ERF_NOALIAS)
     {
       varinfo_t vi;
       struct constraint_expr tmpc;
-      rhsc.create (0);
+      rhsc.truncate (0);
       vi = make_heapvar ("HEAP", true);
       /* We are marking allocated storage local, we deal with it becoming
          global by escaping and setting of vars_contains_escaped_heap.  */
@@ -4435,7 +4435,7 @@ handle_lhs_call (gcall *stmt, tree lhs, int flags, vec<ce_s> &rhsc,
       tmpc.type = ADDRESSOF;
       rhsc.safe_push (tmpc);
       process_all_all_constraints (lhsc, rhsc);
-      rhsc.release ();
+      rhsc.truncate (0);
     }
   else
     process_all_all_constraints (lhsc, rhsc);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-02-23 14:57 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-23 14:57 [gcc r13-6305] Fix memory leak in PTA Richard Biener

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).