[gcc r13-6329] [PR105224] C++ modules and AAPCS/ARM EABI clash on inline key methods

[gcc r13-6329] [PR105224] C++ modules and AAPCS/ARM EABI clash on inline key methods

[Alexandre Oliva]

https://gcc.gnu.org/g:3d1d3ece9bc5a1baa2feb4bf231b709c097b8434

commit r13-6329-g3d1d3ece9bc5a1baa2feb4bf231b709c097b8434
Author: Alexandre Oliva <oliva@adacore.com>
Date:   Fri Feb 24 11:31:05 2023 -0300

    [PR105224] C++ modules and AAPCS/ARM EABI clash on inline key methods
    
    g++.dg/modules/virt-2_a.C fails on arm-eabi and many other arm targets
    that use the AAPCS variant.  ARM is the only target that overrides
    TARGET_CXX_KEY_METHOD_MAY_BE_INLINE.  It's not clear to me which way
    the clash between AAPCS and C++ Modules design should be resolved, but
    currently it favors AAPCS and thus the test fails, so skip it on
    arm_eabi.
    
    
    for  gcc/testsuite/ChangeLog
    
            PR c++/105224
            * g++.dg/modules/virt-2_a.C: Skip on arm_eabi.

Diff:
---
 gcc/testsuite/g++.dg/modules/virt-2_a.C | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gcc/testsuite/g++.dg/modules/virt-2_a.C b/gcc/testsuite/g++.dg/modules/virt-2_a.C
index 580552be5a0..b5050445c3f 100644
--- a/gcc/testsuite/g++.dg/modules/virt-2_a.C
+++ b/gcc/testsuite/g++.dg/modules/virt-2_a.C
@@ -1,3 +1,6 @@
+// AAPCS overrides TARGET_CXX_KEY_METHOD_MAY_BE_INLINE,
+// in a way that invalidates this test.
+// { dg-skip-if "!TARGET_CXX_KEY_METHOD_MAY_BE_INLINE" { arm_eabi } } 
 // { dg-module-do run }
 // { dg-additional-options -fmodules-ts }
 export module foo;