public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Thomas Schwinge <tschwinge@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-6586] OpenACC: Remove 'acc_async_test' -> skip shortcut in 'libgomp/oacc-async.c:goacc_wait'
Date: Fri, 10 Mar 2023 14:39:46 +0000 (GMT)	[thread overview]
Message-ID: <20230310143946.DDFAA3858D38@sourceware.org> (raw)

https://gcc.gnu.org/g:b5037d4a073f2e4625afab5ec1f35624d9f9eba1

commit r13-6586-gb5037d4a073f2e4625afab5ec1f35624d9f9eba1
Author: Thomas Schwinge <thomas@codesourcery.com>
Date:   Fri Feb 24 16:17:57 2023 +0100

    OpenACC: Remove 'acc_async_test' -> skip shortcut in 'libgomp/oacc-async.c:goacc_wait'
    
    We're not taking such a shortcut anywhere else, and (with future changes) it
    has potential to confuse things if synchronization in a libgomp plugin happens
    to have side effects even if an async queue currently is empty.
    
            libgomp/
            * oacc-async.c (goacc_wait): Remove 'acc_async_test' -> skip
            shortcut.

Diff:
---
 libgomp/oacc-async.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/libgomp/oacc-async.c b/libgomp/oacc-async.c
index 2562afbd753..82d00b64b50 100644
--- a/libgomp/oacc-async.c
+++ b/libgomp/oacc-async.c
@@ -410,9 +410,6 @@ goacc_wait (int async, int num_waits, va_list *ap)
 	  break;
 	}
 
-      if (acc_async_test (qid))
-	continue;
-
       if (async == acc_async_sync)
 	acc_wait (qid);
       else if (qid == async)

                 reply	other threads:[~2023-03-10 14:39 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230310143946.DDFAA3858D38@sourceware.org \
    --to=tschwinge@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).