public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-6586] OpenACC: Remove 'acc_async_test' -> skip shortcut in 'libgomp/oacc-async.c:goacc_wait'
@ 2023-03-10 14:39 Thomas Schwinge
  0 siblings, 0 replies; only message in thread
From: Thomas Schwinge @ 2023-03-10 14:39 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:b5037d4a073f2e4625afab5ec1f35624d9f9eba1

commit r13-6586-gb5037d4a073f2e4625afab5ec1f35624d9f9eba1
Author: Thomas Schwinge <thomas@codesourcery.com>
Date:   Fri Feb 24 16:17:57 2023 +0100

    OpenACC: Remove 'acc_async_test' -> skip shortcut in 'libgomp/oacc-async.c:goacc_wait'
    
    We're not taking such a shortcut anywhere else, and (with future changes) it
    has potential to confuse things if synchronization in a libgomp plugin happens
    to have side effects even if an async queue currently is empty.
    
            libgomp/
            * oacc-async.c (goacc_wait): Remove 'acc_async_test' -> skip
            shortcut.

Diff:
---
 libgomp/oacc-async.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/libgomp/oacc-async.c b/libgomp/oacc-async.c
index 2562afbd753..82d00b64b50 100644
--- a/libgomp/oacc-async.c
+++ b/libgomp/oacc-async.c
@@ -410,9 +410,6 @@ goacc_wait (int async, int num_waits, va_list *ap)
 	  break;
 	}
 
-      if (acc_async_test (qid))
-	continue;
-
       if (async == acc_async_sync)
 	acc_wait (qid);
       else if (qid == async)

^ permalink raw reply	[flat|nested] only message in thread
only message in thread, other threads:[~2023-03-10 14:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-10 14:39 [gcc r13-6586] OpenACC: Remove 'acc_async_test' -> skip shortcut in 'libgomp/oacc-async.c:goacc_wait' Thomas Schwinge

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).