public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Andrew Pinski <pinskia@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r14-306] MIN/MAX should be treated similar as comparisons for trapping
Date: Thu, 27 Apr 2023 15:01:09 +0000 (GMT)	[thread overview]
Message-ID: <20230427150109.9CF673858413@sourceware.org> (raw)

https://gcc.gnu.org/g:5fecfed8788eb114508e36e465147f2bb856fa33

commit r14-306-g5fecfed8788eb114508e36e465147f2bb856fa33
Author: Andrew Pinski <apinski@marvell.com>
Date:   Sat Apr 1 22:50:27 2023 +0000

    MIN/MAX should be treated similar as comparisons for trapping
    
    While looking into moving optimizations from minmax_replacement
    in phiopt to match.pd, I Noticed that min/max were considered
    trapping even if -ffinite-math-only was being used. This changes
    those expressions to be similar as comparisons so that they are
    not considered trapping if -ffinite-math-only is on.
    
    OK? Bootstrapped and tested with no regressions on x86_64-linux-gnu.
    
    gcc/ChangeLog:
    
            * rtlanal.cc (may_trap_p_1): Treat SMIN/SMAX similar as
            COMPARISON.
            * tree-eh.cc (operation_could_trap_helper_p): Treate
            MIN_EXPR/MAX_EXPR similar as other comparisons.

Diff:
---
 gcc/rtlanal.cc | 3 +++
 gcc/tree-eh.cc | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/gcc/rtlanal.cc b/gcc/rtlanal.cc
index c96a88cebf1..b7948ecfad1 100644
--- a/gcc/rtlanal.cc
+++ b/gcc/rtlanal.cc
@@ -3204,6 +3204,9 @@ may_trap_p_1 (const_rtx x, unsigned flags)
     case LT:
     case LTGT:
     case COMPARE:
+    /* Treat min/max similar as comparisons.  */
+    case SMIN:
+    case SMAX:
       /* Some floating point comparisons may trap.  */
       if (!flag_trapping_math)
 	break;
diff --git a/gcc/tree-eh.cc b/gcc/tree-eh.cc
index 425323ff7d6..934209d205f 100644
--- a/gcc/tree-eh.cc
+++ b/gcc/tree-eh.cc
@@ -2490,6 +2490,9 @@ operation_could_trap_helper_p (enum tree_code op,
     case GT_EXPR:
     case GE_EXPR:
     case LTGT_EXPR:
+    /* MIN/MAX similar as LT/LE/GT/GE. */
+    case MIN_EXPR:
+    case MAX_EXPR:
       /* Some floating point comparisons may trap.  */
       return honor_nans;

                 reply	other threads:[~2023-04-27 15:01 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230427150109.9CF673858413@sourceware.org \
    --to=pinskia@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).