public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r14-306] MIN/MAX should be treated similar as comparisons for trapping
@ 2023-04-27 15:01 Andrew Pinski
0 siblings, 0 replies; only message in thread
From: Andrew Pinski @ 2023-04-27 15:01 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:5fecfed8788eb114508e36e465147f2bb856fa33
commit r14-306-g5fecfed8788eb114508e36e465147f2bb856fa33
Author: Andrew Pinski <apinski@marvell.com>
Date: Sat Apr 1 22:50:27 2023 +0000
MIN/MAX should be treated similar as comparisons for trapping
While looking into moving optimizations from minmax_replacement
in phiopt to match.pd, I Noticed that min/max were considered
trapping even if -ffinite-math-only was being used. This changes
those expressions to be similar as comparisons so that they are
not considered trapping if -ffinite-math-only is on.
OK? Bootstrapped and tested with no regressions on x86_64-linux-gnu.
gcc/ChangeLog:
* rtlanal.cc (may_trap_p_1): Treat SMIN/SMAX similar as
COMPARISON.
* tree-eh.cc (operation_could_trap_helper_p): Treate
MIN_EXPR/MAX_EXPR similar as other comparisons.
Diff:
---
gcc/rtlanal.cc | 3 +++
gcc/tree-eh.cc | 3 +++
2 files changed, 6 insertions(+)
diff --git a/gcc/rtlanal.cc b/gcc/rtlanal.cc
index c96a88cebf1..b7948ecfad1 100644
--- a/gcc/rtlanal.cc
+++ b/gcc/rtlanal.cc
@@ -3204,6 +3204,9 @@ may_trap_p_1 (const_rtx x, unsigned flags)
case LT:
case LTGT:
case COMPARE:
+ /* Treat min/max similar as comparisons. */
+ case SMIN:
+ case SMAX:
/* Some floating point comparisons may trap. */
if (!flag_trapping_math)
break;
diff --git a/gcc/tree-eh.cc b/gcc/tree-eh.cc
index 425323ff7d6..934209d205f 100644
--- a/gcc/tree-eh.cc
+++ b/gcc/tree-eh.cc
@@ -2490,6 +2490,9 @@ operation_could_trap_helper_p (enum tree_code op,
case GT_EXPR:
case GE_EXPR:
case LTGT_EXPR:
+ /* MIN/MAX similar as LT/LE/GT/GE. */
+ case MIN_EXPR:
+ case MAX_EXPR:
/* Some floating point comparisons may trap. */
return honor_nans;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-04-27 15:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-27 15:01 [gcc r14-306] MIN/MAX should be treated similar as comparisons for trapping Andrew Pinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).