public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc(refs/vendors/riscv/heads/gcc-13-with-riscv-opts)] RISC-V: Prohibit combination of 'E' and 'H'
@ 2023-10-23  2:12 Jeff Law
  0 siblings, 0 replies; only message in thread
From: Jeff Law @ 2023-10-23  2:12 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:17cc344495de08ca322863bede24951e5d01fe42

commit 17cc344495de08ca322863bede24951e5d01fe42
Author: Tsukasa OI <research_trasio@irq.a4lg.com>
Date:   Sat Oct 21 04:28:21 2023 +0000

    RISC-V: Prohibit combination of 'E' and 'H'
    
    According to the ratified privileged specification (version 20211203),
    it says:
    
    > The hypervisor extension depends on an "I" base integer ISA with 32 x
    > registers (RV32I or RV64I), not RV32E, which has only 16 x registers.
    
    Also in the latest draft, it also prohibits RV64E with the 'H' extension.
    This commit prohibits the combination of 'E' and 'H' extensions.
    
    gcc/ChangeLog:
    
            * common/config/riscv/riscv-common.cc (riscv_subset_list::parse):
            Prohibit 'E' and 'H' combinations.
    
    gcc/testsuite/ChangeLog:
    
            * gcc.target/riscv/arch-26.c: New test.
    
    (cherry picked from commit 11f50716eee812c4a27b66f894e7f3ed0c870534)

Diff:
---
 gcc/common/config/riscv/riscv-common.cc  | 4 ++++
 gcc/testsuite/gcc.target/riscv/arch-26.c | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/gcc/common/config/riscv/riscv-common.cc b/gcc/common/config/riscv/riscv-common.cc
index 860c8521b7b6..526dbb7603be 100644
--- a/gcc/common/config/riscv/riscv-common.cc
+++ b/gcc/common/config/riscv/riscv-common.cc
@@ -1495,6 +1495,10 @@ riscv_subset_list::parse (const char *arch, location_t loc)
     error_at (loc, "%<-march=%s%>: z*inx conflicts with floating-point "
 		   "extensions", arch);
 
+  /* 'H' hypervisor extension requires base ISA with 32 registers.  */
+  if (subset_list->lookup ("e") && subset_list->lookup ("h"))
+    error_at (loc, "%<-march=%s%>: h extension requires i extension", arch);
+
   return subset_list;
 
 fail:
diff --git a/gcc/testsuite/gcc.target/riscv/arch-26.c b/gcc/testsuite/gcc.target/riscv/arch-26.c
new file mode 100644
index 000000000000..0b48bc945b58
--- /dev/null
+++ b/gcc/testsuite/gcc.target/riscv/arch-26.c
@@ -0,0 +1,4 @@
+/* { dg-do compile } */
+/* { dg-options "-march=rv32eh -mabi=ilp32e" } */
+int foo() {}
+/* { dg-error "'-march=rv32eh': h extension requires i extension" "" { target *-*-* } 0 } */

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-10-23  2:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-23  2:12 [gcc(refs/vendors/riscv/heads/gcc-13-with-riscv-opts)] RISC-V: Prohibit combination of 'E' and 'H' Jeff Law

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).