public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r14-9007] gccrs: Avoid *.bak suffixed tests - use dg-skip-if instead
@ 2024-02-15 12:57 Jakub Jelinek
0 siblings, 0 replies; only message in thread
From: Jakub Jelinek @ 2024-02-15 12:57 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:f0b1cf01782ba975cfda32800c91076df78058d6
commit r14-9007-gf0b1cf01782ba975cfda32800c91076df78058d6
Author: Jakub Jelinek <jakub@redhat.com>
Date: Thu Feb 15 13:55:49 2024 +0100
gccrs: Avoid *.bak suffixed tests - use dg-skip-if instead
On Fri, Feb 09, 2024 at 11:03:38AM +0100, Jakub Jelinek wrote:
> On Wed, Feb 07, 2024 at 12:43:59PM +0100, arthur.cohen@embecosm.com wrote:
> > This patch introduces one regression because generics are getting better
> > understood over time. The code here used to apply generics with the same
> > symbol from previous segments which was a bit of a hack with out limited
> > inference variable support. The regression looks like it will be related
> > to another issue which needs to default integer inference variables much
> > more aggresivly to default integer.
> >
> > Fixes #2723
> > * rust/compile/issue-1773.rs: Moved to...
> > * rust/compile/issue-1773.rs.bak: ...here.
>
> Please don't use such suffixes in the testsuite.
> Either delete the testcase, or xfail it somehow until the bug is fixed.
To be precise, I have scripts to look for backup files in the tree (*~,
*.bak, *.orig, *.rej etc.) and this stands in the way several times a day.
Here is a fix for that in patch form, tested on x86_64-linux with
make check-rust RUNTESTFLAGS='compile.exp=issue-1773.rs'
2024-02-15 Jakub Jelinek <jakub@redhat.com>
* rust/compile/issue-1773.rs.bak: Rename to ...
* rust/compile/issue-1773.rs: ... this. Add dg-skip-if directive.
Diff:
---
gcc/testsuite/rust/compile/{issue-1773.rs.bak => issue-1773.rs} | 1 +
1 file changed, 1 insertion(+)
diff --git a/gcc/testsuite/rust/compile/issue-1773.rs.bak b/gcc/testsuite/rust/compile/issue-1773.rs
similarity index 89%
rename from gcc/testsuite/rust/compile/issue-1773.rs.bak
rename to gcc/testsuite/rust/compile/issue-1773.rs
index a4542aea00b0..468497a4792e 100644
--- a/gcc/testsuite/rust/compile/issue-1773.rs.bak
+++ b/gcc/testsuite/rust/compile/issue-1773.rs
@@ -1,4 +1,5 @@
#[lang = "sized"]
+// { dg-skip-if "" { *-*-* } }
pub trait Sized {}
trait Foo<T> {
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-02-15 12:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-15 12:57 [gcc r14-9007] gccrs: Avoid *.bak suffixed tests - use dg-skip-if instead Jakub Jelinek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).