From: "Kewen.Lin" <linkw@linux.ibm.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Cc: AlanM <amodra@gmail.com>,
Segher Boessenkool <segher@kernel.crashing.org>,
David Edelsohn <dje.gcc@gmail.com>,
Peter Bergner <bergner@linux.ibm.com>,
Uros Bizjak <ubizjak@gmail.com>,
ian@airs.com, krebbel@linux.ibm.com
Subject: [PATCH] libgcc: Use initarray section type for .init_stack
Date: Mon, 20 Mar 2023 14:33:13 +0800 [thread overview]
Message-ID: <050edd6f-0ad9-fbad-a9e5-03ec7b937971@linux.ibm.com> (raw)
Hi,
One of my workmates found there is a warning like:
libgcc/config/rs6000/morestack.S:402: Warning: ignoring
incorrect section type for .init_array.00000
when compiling libgcc/config/rs6000/morestack.S.
Since commit r13-6545 touched that file recently, which was
suspected to be responsible for this warning, I did some
investigation and found this is a warning staying for a long
time. For section .init_stack*, it's preferred to use
section type SHT_INIT_ARRAY. So this patch is use
"@init_array" to replace "@progbits".
Although the warning is trivial, Segher suggested me to
post this to fix it, in order to avoid any possible
misunderstanding/confusion on the warning.
As Alan confirmed, this doesn't require a premise check
on if the existing binutils supports "@init_array" or not,
"because if you want split-stack to work, you must link
with gold, any version of binutils that has gold has an
assembler that understands @init_array". (Thanks Alan!)
Bootstrapped and regtested on x86_64-redhat-linux
and powerpc64{,le}-linux-gnu.
Is it ok for trunk when next stage 1 comes?
BR,
Kewen
-----
libgcc/ChangeLog:
* config/i386/morestack.S: Use @init_array rather than
@progbits for section type of section .init_array.
* config/rs6000/morestack.S: Likewise.
* config/s390/morestack.S: Likewise.
---
libgcc/config/i386/morestack.S | 2 +-
libgcc/config/rs6000/morestack.S | 2 +-
libgcc/config/s390/morestack.S | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/libgcc/config/i386/morestack.S b/libgcc/config/i386/morestack.S
index 7ae99b50cf5..c822b71e2dd 100644
--- a/libgcc/config/i386/morestack.S
+++ b/libgcc/config/i386/morestack.S
@@ -850,7 +850,7 @@ __morestack_make_guard:
# This is ELF specific.
#if HAVE_INITFINI_ARRAY_SUPPORT
- .section .init_array.00000,"aw",@progbits
+ .section .init_array.00000,"aw",@init_array
#else
.section .ctors.65535,"aw",@progbits
#endif
diff --git a/libgcc/config/rs6000/morestack.S b/libgcc/config/rs6000/morestack.S
index f2fea6abb10..dd1e27cd454 100644
--- a/libgcc/config/rs6000/morestack.S
+++ b/libgcc/config/rs6000/morestack.S
@@ -399,7 +399,7 @@ ENTRY0(__morestack_make_guard)
# Make __stack_split_initialize a high priority constructor.
#if HAVE_INITFINI_ARRAY_SUPPORT
- .section .init_array.00000,"aw",@progbits
+ .section .init_array.00000,"aw",@init_array
#else
.section .ctors.65535,"aw",@progbits
#endif
diff --git a/libgcc/config/s390/morestack.S b/libgcc/config/s390/morestack.S
index 09a49bb8851..f52e7a6510c 100644
--- a/libgcc/config/s390/morestack.S
+++ b/libgcc/config/s390/morestack.S
@@ -597,7 +597,7 @@ __morestack_make_guard:
# Make __stack_split_initialize a high priority constructor.
#if HAVE_INITFINI_ARRAY_SUPPORT
- .section .init_array.00000,"aw",@progbits
+ .section .init_array.00000,"aw",@init_array
#else
.section .ctors.65535,"aw",@progbits
#endif
--
2.31.1
next reply other threads:[~2023-03-20 6:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 6:33 Kewen.Lin [this message]
2023-05-17 6:24 ` PING^1 " Kewen.Lin
2023-05-25 7:25 ` Andreas Krebbel
2023-05-31 7:39 ` Kewen.Lin
2023-05-31 7:45 ` Uros Bizjak
2023-05-31 16:57 ` Ian Lance Taylor
2023-06-05 5:24 ` Kewen.Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=050edd6f-0ad9-fbad-a9e5-03ec7b937971@linux.ibm.com \
--to=linkw@linux.ibm.com \
--cc=amodra@gmail.com \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ian@airs.com \
--cc=krebbel@linux.ibm.com \
--cc=segher@kernel.crashing.org \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).