From: Uros Bizjak <ubizjak@gmail.com>
To: "Kewen.Lin" <linkw@linux.ibm.com>
Cc: Andreas Krebbel <krebbel@linux.ibm.com>,
ian@airs.com, GCC Patches <gcc-patches@gcc.gnu.org>,
Ian Lance Taylor <iant@golang.org>
Subject: Re: [PATCH] libgcc: Use initarray section type for .init_stack
Date: Wed, 31 May 2023 09:45:15 +0200 [thread overview]
Message-ID: <CAFULd4ZiWyQo5byWVcAzDar=53VuHjbxohJmZGLwXxNv18R+pw@mail.gmail.com> (raw)
In-Reply-To: <8a1e58f9-6154-65c1-2785-dbe90d401a3b@linux.ibm.com>
On Wed, May 31, 2023 at 9:40 AM Kewen.Lin <linkw@linux.ibm.com> wrote:
>
> Hi Andreas,
>
> on 2023/5/25 15:25, Andreas Krebbel wrote:
> > On 3/20/23 07:33, Kewen.Lin wrote:
> >> Hi,
> >>
> >> One of my workmates found there is a warning like:
> >>
> >> libgcc/config/rs6000/morestack.S:402: Warning: ignoring
> >> incorrect section type for .init_array.00000
> >>
> >> when compiling libgcc/config/rs6000/morestack.S.
> >>
> >> Since commit r13-6545 touched that file recently, which was
> >> suspected to be responsible for this warning, I did some
> >> investigation and found this is a warning staying for a long
> >> time. For section .init_stack*, it's preferred to use
> >> section type SHT_INIT_ARRAY. So this patch is use
> >> "@init_array" to replace "@progbits".
> >>
> >> Although the warning is trivial, Segher suggested me to
> >> post this to fix it, in order to avoid any possible
> >> misunderstanding/confusion on the warning.
> >>
> >> As Alan confirmed, this doesn't require a premise check
> >> on if the existing binutils supports "@init_array" or not,
> >> "because if you want split-stack to work, you must link
> >> with gold, any version of binutils that has gold has an
> >> assembler that understands @init_array". (Thanks Alan!)
> >>
> >> Bootstrapped and regtested on x86_64-redhat-linux
> >> and powerpc64{,le}-linux-gnu.
> >>
> >> Is it ok for trunk when next stage 1 comes?
> >>
> >> BR,
> >> Kewen
> >> -----
> >> libgcc/ChangeLog:
> >>
> >> * config/i386/morestack.S: Use @init_array rather than
> >> @progbits for section type of section .init_array.
> >> * config/rs6000/morestack.S: Likewise.
> >> * config/s390/morestack.S: Likewise.
> >
> > s390 parts are ok. I did run a bootstrap and regression. Looks all good. Thanks!
>
> Thanks for testing this on s390, really appreciate!
>
> Hi Ian & Uros,
>
> Do you have any concerns on this, or does it look good to you?
LGTM, but morestack.S is mostly used for Go, so I'd defer to Ian for
the final approval.
Uros.
next prev parent reply other threads:[~2023-05-31 7:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 6:33 Kewen.Lin
2023-05-17 6:24 ` PING^1 " Kewen.Lin
2023-05-25 7:25 ` Andreas Krebbel
2023-05-31 7:39 ` Kewen.Lin
2023-05-31 7:45 ` Uros Bizjak [this message]
2023-05-31 16:57 ` Ian Lance Taylor
2023-06-05 5:24 ` Kewen.Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFULd4ZiWyQo5byWVcAzDar=53VuHjbxohJmZGLwXxNv18R+pw@mail.gmail.com' \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ian@airs.com \
--cc=iant@golang.org \
--cc=krebbel@linux.ibm.com \
--cc=linkw@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).