From: Jeff Law <jeffreyalaw@gmail.com>
To: Eric Botcazou <botcazou@adacore.com>,
Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 1/2] gcc/file-prefix-map: Allow remapping of relative paths
Date: Mon, 7 Nov 2022 09:21:25 -0700 [thread overview]
Message-ID: <05c6efad-c842-a2f7-4f4e-9a415e3034db@gmail.com> (raw)
In-Reply-To: <5618710.DvuYhMxLoT@fomalhaut>
On 11/7/22 01:01, Eric Botcazou via Gcc-patches wrote:
>> I can send the obvious patch to make it work as before and ignore the
>> NULL which fixes this. I'm not sure if it should really be passing NULL
>> around in the first place or not which is why I'm sharing the backtrace.
> Thanks for the investigation. That's because the DECL_SOURCE_LOCATION of the
> function is UNKNOWN_LOCATION since:
>
> 2021-08-11 Bernd Edlinger <bernd.edlinger@hotmail.de>
>
> PR debug/101598
> * gcc-interface/trans.c (Subprogram_Body_to_gnu): Set the
> DECL_SOURCE_LOCATION of DECL_IGNORED_P gnu_subprog_decl to
> UNKNOWN_LOCATION.
>
> That's indeed quite irregular but we have to live with it now.
Eric, can you push the approved fix for this issue (look for a message
from Richard P day or two back, approved by Richi)? I'm dealing with a
medical issue and heading offline again momentarily.
jeff
>
next prev parent reply other threads:[~2022-11-07 16:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 12:15 Richard Purdie
2022-08-17 12:15 ` [PATCH 2/2] libcpp: Avoid remapping filenames within directives Richard Purdie
2022-08-17 14:19 ` Richard Purdie
2022-11-01 19:32 ` Jeff Law
2022-11-02 10:52 ` Richard Purdie
2022-11-01 19:46 ` [PATCH 1/2] gcc/file-prefix-map: Allow remapping of relative paths Jeff Law
2023-01-19 13:06 ` Jakub Jelinek
2023-01-20 15:05 ` [PATCH] file-prefix-map: Fix up -f*-prefix-map= [PR108464] Jakub Jelinek
2023-01-23 15:39 ` Jakub Jelinek
2023-03-10 8:49 ` Patch ping - " Jakub Jelinek
2023-03-10 9:05 ` Richard Biener
2023-03-10 10:14 ` Richard Purdie
2022-11-04 9:12 ` [PATCH 1/2] gcc/file-prefix-map: Allow remapping of relative paths Eric Botcazou
2022-11-04 17:21 ` Richard Purdie
2022-11-07 8:01 ` Eric Botcazou
2022-11-07 16:21 ` Jeff Law [this message]
2022-11-07 16:36 ` Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05c6efad-c842-a2f7-4f4e-9a415e3034db@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=botcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).