From: Jakub Jelinek <jakub@redhat.com>
To: Jeff Law <jeffreyalaw@gmail.com>
Cc: Richard Purdie <richard.purdie@linuxfoundation.org>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 1/2] gcc/file-prefix-map: Allow remapping of relative paths
Date: Thu, 19 Jan 2023 14:06:49 +0100 [thread overview]
Message-ID: <Y8lAaabYhgLh90kZ@tucnak> (raw)
In-Reply-To: <40aa90ef-2d06-9c02-be8c-be6b6e2e9b1c@gmail.com>
On Tue, Nov 01, 2022 at 01:46:20PM -0600, Jeff Law via Gcc-patches wrote:
>
> On 8/17/22 06:15, Richard Purdie via Gcc-patches wrote:
> > Relative paths currently aren't remapped by -ffile-prefix-map and friends.
> > When cross compiling with separate 'source' and 'build' directories, the same
> > relative paths between directories may not be available on target as compared
> > to build time.
> >
> > In order to be able to remap these relative build paths to paths that would
> > work on target, resolve paths within the file-prefix-map function using
> > realpath().
>
> Understood.
>
>
> >
> > This does cause a change of behaviour if users were previously relying upon
> > symlinks or absolute paths not being resolved.
>
> I'm not too worried about this scenario.
This breaks ccache testsuite and -fdebug-prefix-map behavior in directories
which are symlinks, see PR108464/ I can't see how the new behavior would be
correct in that case, user is asking to remap say /home/jakub/foobar2 to
some other path, but exactly /home/jakub/foobar2 appears in the debug info,
rather than the other path.
Jakub
next prev parent reply other threads:[~2023-01-19 13:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 12:15 Richard Purdie
2022-08-17 12:15 ` [PATCH 2/2] libcpp: Avoid remapping filenames within directives Richard Purdie
2022-08-17 14:19 ` Richard Purdie
2022-11-01 19:32 ` Jeff Law
2022-11-02 10:52 ` Richard Purdie
2022-11-01 19:46 ` [PATCH 1/2] gcc/file-prefix-map: Allow remapping of relative paths Jeff Law
2023-01-19 13:06 ` Jakub Jelinek [this message]
2023-01-20 15:05 ` [PATCH] file-prefix-map: Fix up -f*-prefix-map= [PR108464] Jakub Jelinek
2023-01-23 15:39 ` Jakub Jelinek
2023-03-10 8:49 ` Patch ping - " Jakub Jelinek
2023-03-10 9:05 ` Richard Biener
2023-03-10 10:14 ` Richard Purdie
2022-11-04 9:12 ` [PATCH 1/2] gcc/file-prefix-map: Allow remapping of relative paths Eric Botcazou
2022-11-04 17:21 ` Richard Purdie
2022-11-07 8:01 ` Eric Botcazou
2022-11-07 16:21 ` Jeff Law
2022-11-07 16:36 ` Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8lAaabYhgLh90kZ@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).