Re: [PATCH][OG12] amdgcn: Support AMD-specific 'isa' and 'arch' traits in OpenMP context selectors

[Andrew Stubbs <ams@codesourcery.com>]

On 01/12/2022 11:10, Paul-Antoine Arras wrote:
> +      if (TARGET_FIJI)                                                         \
> +	builtin_define ("__FIJI__");                                           \
> +      else if (TARGET_VEGA10)                                                  \
> +	builtin_define ("__VEGA10__");                                         \
> +      else if (TARGET_VEGA20)                                                  \
> +	builtin_define ("__VEGA20__");                                         \
> +      else if (TARGET_GFX908)                                                  \
> +	builtin_define ("__GFX908__");                                         \
> +      else if (TARGET_GFX90a)                                                  \
> +	builtin_define ("__GFX90a__");                                         \
> +  } while (0)
>  

I don't think it makes sense to say __VEGA10__ when the user asked for 
-march=gfx900.

This whole naming thing is a bit of a mess already, so I think we'd do 
better to either keep the same names throughout or match what LLVM does 
(since it got to these first).

Please use "__gfx900__" etc. (lower case).

I'm half tempted to do a global search and replace on the internal 
names, but since they're not externally visible that would probably just 
be making merge conflicts for the sake of it.

Thanks

Andrew

P.S. If you want to split the patch into the GCN bits and the bits that 
depend on metadirectives then we can apply the first part to mainline 
right away.