From: Andrew Stubbs <ams@codesourcery.com>
To: Paul-Antoine Arras <pa@codesourcery.com>,
Kwok Cheung Yeung <kcyeung77@gmail.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] amdgcn: Add preprocessor builtins for every processor type
Date: Thu, 1 Dec 2022 14:42:04 +0000 [thread overview]
Message-ID: <b6403f5c-04c8-969f-d0db-1221ecd56bdc@codesourcery.com> (raw)
In-Reply-To: <b3b7e809-537d-c2f0-c02d-b1050967edbd@codesourcery.com>
On 01/12/2022 14:35, Paul-Antoine Arras wrote:
> I believe this patch addresses your comments regarding the GCN bits.
>
> The new builtins are consistent with the LLVM naming convention (lower
> case, canonical name). For gfx803, I also kept '__fiji__' to be
> consistent with -march=fiji.
>
> Is it OK for mainline?
You need to wrap the long line in the changelog (I'm not sure it'll even
let you push it like that), but otherwise it looks fine.
OK.
Andrew
next prev parent reply other threads:[~2022-12-01 14:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 15:32 [PATCH][OG12] amdgcn: Support AMD-specific 'isa' and 'arch' traits in OpenMP context selectors Paul-Antoine Arras
2022-11-30 18:50 ` Kwok Cheung Yeung
2022-12-01 11:10 ` Paul-Antoine Arras
2022-12-01 12:45 ` Andrew Stubbs
2022-12-01 14:35 ` [PATCH] amdgcn: Add preprocessor builtins for every processor type Paul-Antoine Arras
2022-12-01 14:42 ` Andrew Stubbs [this message]
2022-12-01 15:48 ` [PATCH][OG12] amdgcn: Support AMD-specific 'isa' and 'arch' traits in OpenMP context selectors Paul-Antoine Arras
2022-12-02 16:51 ` Kwok Cheung Yeung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6403f5c-04c8-969f-d0db-1221ecd56bdc@codesourcery.com \
--to=ams@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kcyeung77@gmail.com \
--cc=pa@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).