Re: [PATCH 4/7] riscv: Move riscv_block_move_loop to separate file

[Jeff Law <jeffreyalaw@gmail.com>]

On 11/13/22 16:05, Christoph Muellner wrote:
> From: Christoph Müllner <christoph.muellner@vrull.eu>
>
> Let's try to not accumulate too much functionality in one single file
> as this does not really help maintaining or extending the code.
> So in order to add more similar functionality like riscv_block_move_loop
> let's move this function to a separate file.
>
> This change does not do any functional changes.
> It does modify a single line in the existing code,
> that check_GNU_style.py complained about.
>
> gcc/ChangeLog:
>
> 	* config.gcc: Add new object riscv-string.o
> 	* config/riscv/riscv-protos.h (riscv_expand_block_move): Remove
> 	  duplicated prototype and move to new section for
> 	  riscv-string.cc.
> 	* config/riscv/riscv.cc (riscv_block_move_straight): Remove function.
> 	(riscv_adjust_block_mem): Likewise.
> 	(riscv_block_move_loop): Likewise.
> 	(riscv_expand_block_move): Likewise.
> 	* config/riscv/riscv.md (cpymemsi): Move to new section for
> 	  riscv-string.cc.
> 	* config/riscv/t-riscv: Add compile rule for riscv-string.o
> 	* config/riscv/riscv-string.c: New file.

OK.  Note I suspect the commit hooks are going to complain about your 
ChangeLog formatting.


jeff