public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Mikael Morin <morin-mikael@orange.fr>
To: FX <fxcoudert@gmail.com>, Fortran <fortran@gcc.gnu.org>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fortran: add IEEE_QUIET_* and IEEE_SIGNALING_* comparisons
Date: Sat, 17 Sep 2022 13:58:55 +0200	[thread overview]
Message-ID: <0a979a6a-388d-c4e4-53db-032ed8fb9ca6@orange.fr> (raw)
In-Reply-To: <4E0DC1F3-FE18-4C6A-A767-E03A1BA6FCC6@gmail.com>

Le 02/09/2022 à 13:37, FX via Fortran a écrit :
> Hi,
> 
> These operations were added to Fortran 2018, and correspond to well-defined IEEE comparison operations, with defined signaling semantics for NaNs. All are implemented in terms of GCC expressions and built-ins, with no library support needed.
> 
> Bootstrapped and regtested on x86_64-linux, both 32- and 64-bit. Depends on a patch currently under review for the middle-end (https://gcc.gnu.org/pipermail/gcc-patches/2022-September/600840.html).
> 
> OK to commit?
> FX
> 

Hello,

the implementation looks good, but the tests lack checks regarding 
exception status.  This is an important part, I think, and basically 
what makes a difference between the quiet and signaling variants.
As the functions are elemental, a few checks with array values would be 
nice too.
OK with these additional checks.

Mikael

  parent reply	other threads:[~2022-09-17 11:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-02 11:37 FX
2022-09-02 15:37 ` Bernhard Reutner-Fischer
2022-09-02 15:54   ` FX
2022-09-02 16:03     ` Bernhard Reutner-Fischer
2022-09-02 16:17       ` FX
2022-09-17 11:58 ` Mikael Morin [this message]
2023-06-06 19:29 FX Coudert
2023-06-08 12:26 ` Harald Anlauf
2023-06-08 12:26   ` Harald Anlauf
2023-06-10 15:21   ` FX Coudert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a979a6a-388d-c4e4-53db-032ed8fb9ca6@orange.fr \
    --to=morin-mikael@orange.fr \
    --cc=fortran@gcc.gnu.org \
    --cc=fxcoudert@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).