Re: [Patch] More LLP64 fixes and __PIC__ values fixes for PE targets

[Jeff Law <jeffreyalaw@gmail.com>]

On 3/11/23 18:54, Jonathan Yong wrote:
> On 3/11/23 17:29, Jeff Law wrote:
>>
>>
>> On 2/14/23 03:42, Jonathan Yong via Gcc-patches wrote:
>>> Attached patches OK?
>>>
>>> 0002-gcc-testsuite-gcc.dg-fix-pic-test-case-for-PE-target.patch
>>>
>>>  From 616e43ac41879040e73a266065874148553cddcc Mon Sep 17 00:00:00 2001
>>> From: Jonathan Yong<10walls@gmail.com>
>>> Date: Tue, 14 Feb 2023 10:37:03 +0000
>>> Subject: [PATCH 2/2] gcc/testsuite/gcc.dg: fix pic test case for PE 
>>> targets
>>>
>>> gcc/testsuite/ChangeLog:
>>>
>>>     * pic-2.c: fix expected __PIC__ value.
>>>     * pic-3.c: ditto.
>>>     * pic-4.c: ditto.
>> Please adjust your ChangeLog entries slightly, in particular, please 
>> capitalize the first letter in each ChangeLog entry.  ie, fix->Fix, 
>> ditto->Ditto.
>>
>> Presumably the windows platforms are not always PIC and thus should 
>> not be handled in a manner similar to MIPS?
>>
>> Assuming that's the case, then this patch is OK with the trivial 
>> ChangeLog fixes.
>>
>>
> 
> Windows code is effectively always PIC, since the PE loader can relocate 
> it anywhere if the preferred address is already occupied. Patch still OK?
Yes, still OK.  Just make the trivial ChangeLog adjustments.

Thanks,
jeff