Re: [Patch] More LLP64 fixes and __PIC__ values fixes for PE targets

[Jeff Law <jeffreyalaw@gmail.com>]

On 2/14/23 03:42, Jonathan Yong via Gcc-patches wrote:
> Attached patches OK?
> 
> 0002-gcc-testsuite-gcc.dg-fix-pic-test-case-for-PE-target.patch
> 
>  From 616e43ac41879040e73a266065874148553cddcc Mon Sep 17 00:00:00 2001
> From: Jonathan Yong<10walls@gmail.com>
> Date: Tue, 14 Feb 2023 10:37:03 +0000
> Subject: [PATCH 2/2] gcc/testsuite/gcc.dg: fix pic test case for PE targets
> 
> gcc/testsuite/ChangeLog:
> 
> 	* pic-2.c: fix expected __PIC__ value.
> 	* pic-3.c: ditto.
> 	* pic-4.c: ditto.
Please adjust your ChangeLog entries slightly, in particular, please 
capitalize the first letter in each ChangeLog entry.  ie, fix->Fix, 
ditto->Ditto.

Presumably the windows platforms are not always PIC and thus should not 
be handled in a manner similar to MIPS?

Assuming that's the case, then this patch is OK with the trivial 
ChangeLog fixes.


> 
> 
> 0001-gcc-testsuite-gcc.dg-fix-LLP64-targets.patch
> 
>  From a1fafc5a3c70684e843f5f0b6cf392ce349cb6b0 Mon Sep 17 00:00:00 2001
> From: Jonathan Yong<10walls@gmail.com>
> Date: Tue, 14 Feb 2023 10:29:05 +0000
> Subject: [PATCH 1/2] gcc/testsuite/gcc.dg: fix LLP64 targets
> 
> gcc/testsuite/ChangeLog:
> 
> 	* gcc.dg/builtins-69.c: Use (long )*regex pattern to
> 	allow long long instead of just long.
> 	* gcc.dg/pr80163.c: use __INTPTR_TYPE__ for LLP64 tagets.
OK with the trivial ChangeLog fix use->Use for the change to pr80163.c.

jeff