From: Pedro Alves <pedro@palves.net>
To: Jonathan Wakely <jwakely.gcc@gmail.com>
Cc: David Malcolm <dmalcolm@redhat.com>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 1/2] Add gcc/make-unique.h
Date: Tue, 12 Jul 2022 19:56:01 +0100 [thread overview]
Message-ID: <17033795-0a8d-f624-0710-64811aaee8d2@palves.net> (raw)
In-Reply-To: <CAH6eHdQK1JUOPB8eczeSQh-6DdCvUncTtJJeeVNwgpmCeWo9eA@mail.gmail.com>
On 2022-07-12 7:50 p.m., Jonathan Wakely wrote:
> Yeah, and I don't think optimizing for indentation is the right trade off. Putting something in a namespace with a three-letter name just so you don't have to re-indent some statements in a few years seems odd.
>
> I see no technical difficulty replacing a custom make_unique (in any namespace) with std::make_unique at a later date.
>
> If a namespace made sense to avoid name clashes, or to enable finding functions by ADL, or other technical reasons, I'd be all for it. But no such rationale was given, and using a namespace for indentation just seems odd to me.
>
> But I really don't care. Putting it in the global namespace or a 'gcc' namespace or anything else appropriate to GCC is fine. I'll leave this thread now. I don't think this is very constructive and I'm sorry for objecting to the suggestion.
That's fair. Cheers! Hope we'll be able to laugh about it in Prague!
next prev parent reply other threads:[~2022-07-12 18:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAH6eHdSnGwtScODMveYha1S5WiDo6YsexN_pRqe9n4vq-Pmkig@mail.gmail.com>
2022-07-12 0:25 ` David Malcolm
2022-07-12 0:25 ` [PATCH 2/2] analyzer: use std::unique_ptr for pending_diagnostic/note David Malcolm
2022-07-12 6:48 ` [PATCH 1/2] Add gcc/make-unique.h Jonathan Wakely
2022-07-12 8:13 ` Jonathan Wakely
2022-10-26 20:40 ` [PATCH v3] " David Malcolm
2022-11-02 21:45 ` Jason Merrill
2022-07-12 13:23 ` [PATCH 1/2] " Pedro Alves
2022-07-12 13:45 ` Jonathan Wakely
2022-07-12 14:06 ` Pedro Alves
2022-07-12 15:14 ` Jonathan Wakely
2022-07-12 16:40 ` Pedro Alves
2022-07-12 18:22 ` Jonathan Wakely
2022-07-12 18:36 ` Pedro Alves
2022-07-12 18:41 ` Pedro Alves
2022-07-12 18:58 ` Jonathan Wakely
2022-07-12 18:59 ` Jonathan Wakely
2022-07-12 18:50 ` Jonathan Wakely
2022-07-12 18:56 ` Pedro Alves [this message]
2022-07-12 18:36 ` David Malcolm
2022-07-12 18:49 ` Pedro Alves
2022-10-21 16:01 David Malcolm
2022-10-25 23:00 ` David Malcolm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17033795-0a8d-f624-0710-64811aaee8d2@palves.net \
--to=pedro@palves.net \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).