public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Aldy Hernandez <aldyh@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: GCC patches <gcc-patches@gcc.gnu.org>,
	Andrew MacLeod <amacleod@redhat.com>
Subject: Re: [PATCH] v2: Implement range-op entry for sin/cos
Date: Thu, 27 Apr 2023 13:46:19 +0200	[thread overview]
Message-ID: <1c53d864-274c-33b9-d80a-16d4137d6100@redhat.com> (raw)
In-Reply-To: <ZEpYvaNqvI7Mfi6u@tucnak>



On 4/27/23 13:13, Jakub Jelinek wrote:

> +    unsigned bulps = targetm.libm_function_max_error (m_cfn, TYPE_MODE (type),
> +						      true);
> +    if (bulps == ~0U)
> +      r.set_varying (type);
> +    else if (bulps == 0)
> +      r.set (type, dconstm1, dconst1);
> +    else
> +      {
> +	REAL_VALUE_TYPE boundmin, boundmax;
> +	boundmax = dconst1;
> +	while (bulps--)
> +	  frange_nextafter (TYPE_MODE (type), boundmax, dconstinf);
> +	real_arithmetic (&boundmin, NEGATE_EXPR, &boundmax, NULL);
> +	r.set (type, boundmin, boundmax);
> +      }

This seems like something we'll do over and over for other operations, 
right?  If so, could you abstract it into a separate function?

Thanks.
Aldy


  reply	other threads:[~2023-04-27 11:46 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-18 13:12 [PATCH] " Aldy Hernandez
2023-04-20 12:59 ` Jakub Jelinek
2023-04-20 13:17   ` Siddhesh Poyarekar
2023-04-20 14:02     ` Jakub Jelinek
2023-04-20 14:20       ` Jakub Jelinek
2023-04-20 15:22       ` Siddhesh Poyarekar
2023-04-20 15:52         ` Jakub Jelinek
2023-04-20 17:57           ` Siddhesh Poyarekar
2023-04-21  1:14             ` Siddhesh Poyarekar
2023-04-21  6:52               ` Jakub Jelinek
2023-04-21 11:20                 ` Siddhesh Poyarekar
2023-04-25  8:59                 ` Aldy Hernandez
2023-04-24 16:03             ` Jakub Jelinek
2023-04-24 16:05               ` Siddhesh Poyarekar
2023-04-24 16:09                 ` Jakub Jelinek
2023-04-24 16:33                 ` Jeff Law
2023-04-21 16:40   ` Jakub Jelinek
2023-04-21 20:43     ` Mikael Morin
2023-04-21 20:45       ` Jakub Jelinek
2023-04-25  9:10       ` Aldy Hernandez
2023-04-25  9:08     ` Aldy Hernandez
2023-04-27 11:13 ` [PATCH] v2: " Jakub Jelinek
2023-04-27 11:46   ` Aldy Hernandez [this message]
2023-04-27 11:53     ` Jakub Jelinek
2023-04-27 12:03       ` Aldy Hernandez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c53d864-274c-33b9-d80a-16d4137d6100@redhat.com \
    --to=aldyh@redhat.com \
    --cc=amacleod@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).