From: Aldy Hernandez <aldyh@redhat.com>
To: Mikael Morin <morin-mikael@orange.fr>,
Jakub Jelinek <jakub@redhat.com>,
"Joseph S. Myers" <joseph@codesourcery.com>,
GCC patches <gcc-patches@gcc.gnu.org>,
Andrew MacLeod <amacleod@redhat.com>
Subject: Re: [PATCH] Implement range-op entry for sin/cos.
Date: Tue, 25 Apr 2023 11:10:00 +0200 [thread overview]
Message-ID: <1d8e027e-1eae-f5b0-13a0-14e4d0aeed9b@redhat.com> (raw)
In-Reply-To: <4772e205-2123-1fa6-1cd6-8bd6ee22b439@orange.fr>
On 4/21/23 22:43, Mikael Morin wrote:
> Hello,
>
>> --- gcc/gimple-range-op.cc.jj 2023-04-21 17:09:48.250367999 +0200
>> +++ gcc/gimple-range-op.cc 2023-04-21 18:37:26.048325391 +0200
>> @@ -439,20 +436,38 @@ public:
>> r.set_varying (type);
>> return true;
>> }
>> +
>> // Results outside of [-1.0, +1.0] are impossible.
>> REAL_VALUE_TYPE lb = lhs.lower_bound ();
>> REAL_VALUE_TYPE ub = lhs.upper_bound ();
>> - if (real_less (&lb, &dconstm1)
>> - || real_less (&dconst1, &ub))
>> + if (real_less (&lb, &dconstm1) || real_less (&dconst1, &ub))
>> {
>
> Shouldn't lb and ub be swapped in this condition?
> If I understand correctly, we are looking for ranges like [whatever,x]
> where x < -1.0 or [y, whatever] where 1.0 < y.
>
> Mikael
>
Thanks. Merged into the latest revision.
Aldy
next prev parent reply other threads:[~2023-04-25 9:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 13:12 Aldy Hernandez
2023-04-20 12:59 ` Jakub Jelinek
2023-04-20 13:17 ` Siddhesh Poyarekar
2023-04-20 14:02 ` Jakub Jelinek
2023-04-20 14:20 ` Jakub Jelinek
2023-04-20 15:22 ` Siddhesh Poyarekar
2023-04-20 15:52 ` Jakub Jelinek
2023-04-20 17:57 ` Siddhesh Poyarekar
2023-04-21 1:14 ` Siddhesh Poyarekar
2023-04-21 6:52 ` Jakub Jelinek
2023-04-21 11:20 ` Siddhesh Poyarekar
2023-04-25 8:59 ` Aldy Hernandez
2023-04-24 16:03 ` Jakub Jelinek
2023-04-24 16:05 ` Siddhesh Poyarekar
2023-04-24 16:09 ` Jakub Jelinek
2023-04-24 16:33 ` Jeff Law
2023-04-21 16:40 ` Jakub Jelinek
2023-04-21 20:43 ` Mikael Morin
2023-04-21 20:45 ` Jakub Jelinek
2023-04-25 9:10 ` Aldy Hernandez [this message]
2023-04-25 9:08 ` Aldy Hernandez
2023-04-27 11:13 ` [PATCH] v2: " Jakub Jelinek
2023-04-27 11:46 ` Aldy Hernandez
2023-04-27 11:53 ` Jakub Jelinek
2023-04-27 12:03 ` Aldy Hernandez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d8e027e-1eae-f5b0-13a0-14e4d0aeed9b@redhat.com \
--to=aldyh@redhat.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=joseph@codesourcery.com \
--cc=morin-mikael@orange.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).