public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: Jakub Jelinek <jakub@redhat.com>,
	Aldy Hernandez <aldyh@redhat.com>,
	"Joseph S. Myers" <joseph@codesourcery.com>
Cc: GCC patches <gcc-patches@gcc.gnu.org>,
	Andrew MacLeod <amacleod@redhat.com>
Subject: Re: [PATCH] Implement range-op entry for sin/cos.
Date: Thu, 20 Apr 2023 09:17:10 -0400	[thread overview]
Message-ID: <cc08dc41-b90a-9012-58e7-3a7ec2c3cfa1@gotplt.org> (raw)
In-Reply-To: <ZEE3N0N481J+i0Gi@tucnak>

On 2023-04-20 08:59, Jakub Jelinek via Gcc-patches wrote:
>> +    r.set (type, dconstm1, dconst1);
> 
> See above, are we sure we can use [-1., 1.] range safely, or should that be
> [-1.-Nulps, 1.+Nulps] for some kind of expected worse error margin of the
> implementation?  And ditto for -frounding-math, shall we increase that
> interval in that case, or is [-1., 1.] going to be ok?

Do any math implementations generate results outside of [-1., 1.]?  If 
yes, then it's a bug in those implementations IMO, not in the range 
assumption.  It feels wrong to cater for what ought to be trivially 
fixable in libraries if they ever happen to generate such results.

Thanks,
Sid

  reply	other threads:[~2023-04-20 13:17 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-18 13:12 Aldy Hernandez
2023-04-20 12:59 ` Jakub Jelinek
2023-04-20 13:17   ` Siddhesh Poyarekar [this message]
2023-04-20 14:02     ` Jakub Jelinek
2023-04-20 14:20       ` Jakub Jelinek
2023-04-20 15:22       ` Siddhesh Poyarekar
2023-04-20 15:52         ` Jakub Jelinek
2023-04-20 17:57           ` Siddhesh Poyarekar
2023-04-21  1:14             ` Siddhesh Poyarekar
2023-04-21  6:52               ` Jakub Jelinek
2023-04-21 11:20                 ` Siddhesh Poyarekar
2023-04-25  8:59                 ` Aldy Hernandez
2023-04-24 16:03             ` Jakub Jelinek
2023-04-24 16:05               ` Siddhesh Poyarekar
2023-04-24 16:09                 ` Jakub Jelinek
2023-04-24 16:33                 ` Jeff Law
2023-04-21 16:40   ` Jakub Jelinek
2023-04-21 20:43     ` Mikael Morin
2023-04-21 20:45       ` Jakub Jelinek
2023-04-25  9:10       ` Aldy Hernandez
2023-04-25  9:08     ` Aldy Hernandez
2023-04-27 11:13 ` [PATCH] v2: " Jakub Jelinek
2023-04-27 11:46   ` Aldy Hernandez
2023-04-27 11:53     ` Jakub Jelinek
2023-04-27 12:03       ` Aldy Hernandez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc08dc41-b90a-9012-58e7-3a7ec2c3cfa1@gotplt.org \
    --to=siddhesh@gotplt.org \
    --cc=aldyh@redhat.com \
    --cc=amacleod@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=joseph@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).