From: Patrick O'Neill <patrick@rivosinc.com>
To: Joern Rennecke <joern.rennecke@embecosm.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Cc: "juzhe.zhong@rivai.ai" <juzhe.zhong@rivai.ai>,
"kito.cheng" <kito.cheng@gmail.com>,
"Kito.cheng" <kito.cheng@sifive.com>,
Robin Dapp <rdapp.gcc@gmail.com>,
Jeff Law <JeffreyALaw@gmail.com>
Subject: Re: [RISC-V]: Re: cpymem for RISCV with v extension
Date: Wed, 4 Oct 2023 10:38:38 -0700 [thread overview]
Message-ID: <1c7393c8-e17d-cf12-d051-acc9599d3669@rivosinc.com> (raw)
In-Reply-To: <CAMqJFCpyPBkF-3hj2DiBLPm0TTP8R9RmyPqMEYjmk10MFp3qoQ@mail.gmail.com>
Hi Joern,
I'm seeing new failures introduced by this patch
(9464e72bcc9123b619215af8cfef491772a3ebd9).
On rv64gcv:
FAIL: gcc.dg/pr90263.c scan-assembler memcpy
FAIL: gfortran.fortran-torture/execute/intrinsic_count.f90 execution,
-O2 -fomit-frame-pointer -finline-functions -funroll-loops
Debug log for intrinsic_count.f90:
spawn riscv64-unknown-linux-gnu-run
/scratch/tc-testing/tc-410-break/build/build-gcc-linux-stage2/gcc/testsuite/gfortran9/intrinsic_count.x
STOP 2
FAIL: gfortran.fortran-torture/execute/intrinsic_count.f90 execution,
-O2 -fomit-frame-pointer -finline-functions -funroll-loops
It's worth noting that intrinsic_count.f90 had failures prior to this
patch for other option combinations:
FAIL: gfortran.fortran-torture/execute/intrinsic_count.f90 execution, -O2
FAIL: gfortran.fortran-torture/execute/intrinsic_count.f90 execution,
-O2 -fbounds-check
FAIL: gfortran.fortran-torture/execute/intrinsic_count.f90 execution,
-O2 -fomit-frame-pointer -finline-functions
Thanks,
Patrick
On 10/1/23 19:43, Joern Rennecke wrote:
> On Tue, 15 Aug 2023 at 15:06, Jeff Law <jeffreyalaw@gmail.com> wrote:
> >
>> On 8/15/23 03:16, juzhe.zhong@rivai.ai wrote:
>>> The new patch looks reasonable to me now. Thanks for fixing it.
>>>
>>> Could you append testcase after finishing test infrastructure ?
>>> I prefer this patch with testcase after infrastructure.
>> So let's call this an ACK, but ask that Joern not commit until the
>> testsuite bits are in place.
> Beyond the adding of tests, the patch needed some changes because of the
> Refactoring of emit_{vlmax,nonvlmax}_xxx functions .
> Attached is the committed version.
next prev parent reply other threads:[~2023-10-04 17:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 23:10 钟居哲
2023-08-04 23:17 ` Jeff Law
2023-08-04 23:34 ` 钟居哲
2023-08-15 8:12 ` Joern Rennecke
2023-08-15 9:16 ` juzhe.zhong
2023-08-15 14:06 ` Jeff Law
2023-10-02 2:43 ` [RISC-V]: " Joern Rennecke
2023-10-04 17:38 ` Patrick O'Neill [this message]
2023-10-04 19:19 ` Joern Rennecke
2023-10-04 21:35 ` Patrick O'Neill
2023-08-15 14:04 ` Jeff Law
2023-08-04 23:44 ` 钟居哲
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c7393c8-e17d-cf12-d051-acc9599d3669@rivosinc.com \
--to=patrick@rivosinc.com \
--cc=JeffreyALaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joern.rennecke@embecosm.com \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@gmail.com \
--cc=kito.cheng@sifive.com \
--cc=rdapp.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).