From: Patrick O'Neill <patrick@rivosinc.com>
To: Joern Rennecke <joern.rennecke@embecosm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
"juzhe.zhong@rivai.ai" <juzhe.zhong@rivai.ai>,
"kito.cheng" <kito.cheng@gmail.com>,
"Kito.cheng" <kito.cheng@sifive.com>,
Robin Dapp <rdapp.gcc@gmail.com>,
Jeff Law <JeffreyALaw@gmail.com>
Subject: Re: [RISC-V]: Re: cpymem for RISCV with v extension
Date: Wed, 4 Oct 2023 14:35:56 -0700 [thread overview]
Message-ID: <8fb497f5-04a9-dbd2-ced3-366f912ef174@rivosinc.com> (raw)
In-Reply-To: <CAMqJFCp6LAH2zS1FxORNyR1H+ShCBPUB7BWxHCbGPZim=vh00Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1698 bytes --]
On 10/4/23 12:19, Joern Rennecke wrote:
> On Wed, 4 Oct 2023 at 18:38, Patrick O'Neill<patrick@rivosinc.com> wrote:
>> Hi Joern,
>>
>> I'm seeing new failures introduced by this patch
>> (9464e72bcc9123b619215af8cfef491772a3ebd9).
>>
>> On rv64gcv:
>> FAIL: gcc.dg/pr90263.c scan-assembler memcpy
> My testing didn't flag this because I used elf targets. The
> expected behaviour now is to use vector instructions for rvv.
> so we shouldn't expect memcpy to appear there. I think the
> rvv case is suitably covered by the new tests, so we just
> have to avoid the failure here. Does the attached patch work for you?
Thanks for the quick response. I'm glad to hear the behavior is expected :)
The attached patch works, just needed some syntax changes:
ERROR: gcc.dg/pr90263.c: error executing dg-final: syntax error in target selector "target i?86-*-* x86_64-*-* riscv_v"
Diff w/ syntax changes:
diff --git a/gcc/testsuite/gcc.dg/pr90263.c b/gcc/testsuite/gcc.dg/pr90263.c
index 3222a5331c1..4044e6b1544 100644
--- a/gcc/testsuite/gcc.dg/pr90263.c
+++ b/gcc/testsuite/gcc.dg/pr90263.c
@@ -9,4 +9,4 @@ int *f (int *p, int *q, long n)
}
/* { dg-final { scan-assembler "mempcpy" { target { i?86-*-* x86_64-*-* } } } } */
-/* { dg-final { scan-assembler "memcpy" { target { ! { i?86-*-* x86_64-*-* } } } } } */
+/* { dg-final { scan-assembler "memcpy" { target { ! { { i?86-*-* x86_64-*-* } || { riscv_v } } } } } } */
I'll send it as a patch shortly.
Patrick
>> FAIL: gfortran.fortran-torture/execute/intrinsic_count.f90 execution,
>> -O2 -fomit-frame-pointer -finline-functions -funroll-loops
> There seems to be an issue with my test setup regarding fortran, I'll
> have to investigate.
next prev parent reply other threads:[~2023-10-04 21:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 23:10 钟居哲
2023-08-04 23:17 ` Jeff Law
2023-08-04 23:34 ` 钟居哲
2023-08-15 8:12 ` Joern Rennecke
2023-08-15 9:16 ` juzhe.zhong
2023-08-15 14:06 ` Jeff Law
2023-10-02 2:43 ` [RISC-V]: " Joern Rennecke
2023-10-04 17:38 ` Patrick O'Neill
2023-10-04 19:19 ` Joern Rennecke
2023-10-04 21:35 ` Patrick O'Neill [this message]
2023-08-15 14:04 ` Jeff Law
2023-08-04 23:44 ` 钟居哲
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fb497f5-04a9-dbd2-ced3-366f912ef174@rivosinc.com \
--to=patrick@rivosinc.com \
--cc=JeffreyALaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joern.rennecke@embecosm.com \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@gmail.com \
--cc=kito.cheng@sifive.com \
--cc=rdapp.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).