From: Jeff Law <jeffreyalaw@gmail.com>
To: Juzhe-Zhong <juzhe.zhong@rivai.ai>, gcc-patches@gcc.gnu.org
Subject: Re: [Committed] RISC-V: Use MAX instead of std::max [VSETVL PASS]
Date: Sun, 7 Jan 2024 12:11:25 -0700 [thread overview]
Message-ID: <1cfa6078-0cfc-4192-b44f-a0751babe6aa@gmail.com> (raw)
In-Reply-To: <20240107003654.1629705-1-juzhe.zhong@rivai.ai>
On 1/6/24 17:36, Juzhe-Zhong wrote:
> Obvious fix, Committed.
>
> gcc/ChangeLog:
>
> * config/riscv/riscv-vsetvl.cc: replace std::max by MAX.
Curious why you made this change -- in general we're moving to
std::{min,max,swap} and away from macro-ized min/max/swap.
Jeff
next prev parent reply other threads:[~2024-01-07 19:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-07 0:36 Juzhe-Zhong
2024-01-07 19:11 ` Jeff Law [this message]
2024-01-07 23:07 ` 钟居哲
2024-01-09 14:38 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cfa6078-0cfc-4192-b44f-a0751babe6aa@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=juzhe.zhong@rivai.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).