From: Jeff Law <jeffreyalaw@gmail.com>
To: 钟居哲 <juzhe.zhong@rivai.ai>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Committed] RISC-V: Use MAX instead of std::max [VSETVL PASS]
Date: Tue, 9 Jan 2024 07:38:44 -0700 [thread overview]
Message-ID: <9ca8e885-2d8a-4ea6-9446-deb063f0e098@gmail.com> (raw)
In-Reply-To: <905DF2A81F1936B9+2024010807071657939231@rivai.ai>
On 1/7/24 16:07, 钟居哲 wrote:
> Since in the previous review from Robin, he have ever asked me change
> std::max into MAX,
> I thought the policy is preferring MAX instead of std::max.
>
> I change the codes to make them consistent but it seems I am wrong.
>
> So is it reasonable that I change all RVV-related codes back to use
> std::max/min ?
>
> If yes, I can send a patch to adapt all of them in RVV related codes.
If Robin asked for MAX, let's leave it as-is. It's not a hard
requirement, just a general direction towards std:: when we can. It may
be the case that with other codes using MAX nearby that keeping
consistency is better.
jeff
prev parent reply other threads:[~2024-01-09 14:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-07 0:36 Juzhe-Zhong
2024-01-07 19:11 ` Jeff Law
2024-01-07 23:07 ` 钟居哲
2024-01-09 14:38 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ca8e885-2d8a-4ea6-9446-deb063f0e098@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=juzhe.zhong@rivai.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).