* [PATCH 2/2] Revert maybe_ne -> known_ne change in vn_reference_lookup_3
@ 2022-07-01 12:19 Richard Biener
2022-07-01 12:34 ` Richard Sandiford
0 siblings, 1 reply; 2+ messages in thread
From: Richard Biener @ 2022-07-01 12:19 UTC (permalink / raw)
To: gcc-patches
This reverts the change as discussed.
Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed.
2022-07-01 Richard Biener <rguenther@suse.de>
* tree-ssa-sccvn.cc (vn_reference_lookup_3): Revert
back to using maybe_ne (off, -1).
---
gcc/tree-ssa-sccvn.cc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gcc/tree-ssa-sccvn.cc b/gcc/tree-ssa-sccvn.cc
index c40c45ed840..f41d5031365 100644
--- a/gcc/tree-ssa-sccvn.cc
+++ b/gcc/tree-ssa-sccvn.cc
@@ -3243,12 +3243,12 @@ vn_reference_lookup_3 (ao_ref *ref, tree vuse, void *data_,
poly_int64 extra_off = 0;
if (j == 0 && i >= 0
&& lhs_ops[0].opcode == MEM_REF
- && known_ne (lhs_ops[0].off, -1))
+ && maybe_ne (lhs_ops[0].off, -1))
{
if (known_eq (lhs_ops[0].off, vr->operands[i].off))
i--, j--;
else if (vr->operands[i].opcode == MEM_REF
- && known_ne (vr->operands[i].off, -1))
+ && maybe_ne (vr->operands[i].off, -1))
{
extra_off = vr->operands[i].off - lhs_ops[0].off;
i--, j--;
--
2.35.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] Revert maybe_ne -> known_ne change in vn_reference_lookup_3
2022-07-01 12:19 [PATCH 2/2] Revert maybe_ne -> known_ne change in vn_reference_lookup_3 Richard Biener
@ 2022-07-01 12:34 ` Richard Sandiford
0 siblings, 0 replies; 2+ messages in thread
From: Richard Sandiford @ 2022-07-01 12:34 UTC (permalink / raw)
To: Richard Biener via Gcc-patches; +Cc: Richard Biener
Richard Biener via Gcc-patches <gcc-patches@gcc.gnu.org> writes:
> This reverts the change as discussed.
Thanks!
> Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed.
>
> 2022-07-01 Richard Biener <rguenther@suse.de>
>
> * tree-ssa-sccvn.cc (vn_reference_lookup_3): Revert
> back to using maybe_ne (off, -1).
> ---
> gcc/tree-ssa-sccvn.cc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/tree-ssa-sccvn.cc b/gcc/tree-ssa-sccvn.cc
> index c40c45ed840..f41d5031365 100644
> --- a/gcc/tree-ssa-sccvn.cc
> +++ b/gcc/tree-ssa-sccvn.cc
> @@ -3243,12 +3243,12 @@ vn_reference_lookup_3 (ao_ref *ref, tree vuse, void *data_,
> poly_int64 extra_off = 0;
> if (j == 0 && i >= 0
> && lhs_ops[0].opcode == MEM_REF
> - && known_ne (lhs_ops[0].off, -1))
> + && maybe_ne (lhs_ops[0].off, -1))
> {
> if (known_eq (lhs_ops[0].off, vr->operands[i].off))
> i--, j--;
> else if (vr->operands[i].opcode == MEM_REF
> - && known_ne (vr->operands[i].off, -1))
> + && maybe_ne (vr->operands[i].off, -1))
> {
> extra_off = vr->operands[i].off - lhs_ops[0].off;
> i--, j--;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-01 12:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-01 12:19 [PATCH 2/2] Revert maybe_ne -> known_ne change in vn_reference_lookup_3 Richard Biener
2022-07-01 12:34 ` Richard Sandiford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).