From: Segher Boessenkool <segher@kernel.crashing.org>
To: "Kewen.Lin" <linkw@linux.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
David Edelsohn <dje.gcc@gmail.com>, AlanM <amodra@gmail.com>
Subject: Re: [PATCH v3] rs6000: Rework ELFv2 support for -fpatchable-function-entry* [PR99888]
Date: Thu, 18 Aug 2022 12:34:35 -0500 [thread overview]
Message-ID: <20220818173435.GN25951@gate.crashing.org> (raw)
In-Reply-To: <c115b433-85a5-616f-2f3d-00ab64d9a9f1@linux.ibm.com>
Hi!
On Thu, Aug 18, 2022 at 10:12:48AM +0800, Kewen.Lin wrote:
> As PR99888 and its related show, the current support for
> -fpatchable-function-entry on powerpc ELFv2 doesn't work
> well with global entry existence.
> + /* Emit the NOPs after local entry. */
Please do not say "NOPs". It is not an acronym. I know some of our
documentation has this bug already, but please do not spread it further.
The machine instruction is "nop", lowercase.
Please fix this.
So, this patch overloads the meaning of the two parameters here to have
more meaning than explained in the documentation for the option. There
isn't much that can be done about this, so adding some new option would
only be extra work for everyone. But, could you add a line or two in
the documentation? "For PowerPC with the ELFv2 ABI, there will be M
nops before the local entry point, and N-M after", something like that?
Segher
next prev parent reply other threads:[~2022-08-18 17:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 2:12 Kewen.Lin
2022-08-18 17:34 ` Segher Boessenkool [this message]
2022-08-19 2:40 ` Kewen.Lin
2022-08-23 14:33 ` Segher Boessenkool
2022-08-24 7:30 ` Kewen.Lin
2022-08-24 14:01 ` Segher Boessenkool
2022-08-25 6:02 ` Kewen.Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220818173435.GN25951@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=amodra@gmail.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=linkw@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).