From: "Kewen.Lin" <linkw@linux.ibm.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
David Edelsohn <dje.gcc@gmail.com>, AlanM <amodra@gmail.com>
Subject: Re: [PATCH v3] rs6000: Rework ELFv2 support for -fpatchable-function-entry* [PR99888]
Date: Thu, 25 Aug 2022 14:02:07 +0800 [thread overview]
Message-ID: <a25db3d6-a7f9-508b-9959-f702204cd0ca@linux.ibm.com> (raw)
In-Reply-To: <20220824140141.GY25951@gate.crashing.org>
on 2022/8/24 22:01, Segher Boessenkool wrote:
> On Wed, Aug 24, 2022 at 03:30:51PM +0800, Kewen.Lin wrote:
>> on 2022/8/23 22:33, Segher Boessenkool wrote:
>> I thought if we can consider [1] and updated the documentation similarly
>> like "For PowerPC with the ELFv2 ABI, there will be M nops before the global
>> entry point, and N-M after the local entry point".
>
> But that does not agree with the documentation. The N nops have to be
> consecutive. If you want to support adding separate nop regions before
> the LEP and GEP entry points, that is fine, but it will need a separate
> command line option.
>
OK, previously I thought if we can claim GEP and LEP (and the area between) as
one special function entry (area) in documentation, but admittedly it's too tricky.
Adding one separated command line option now just for one potential use case in
future seems not a good idea. Following the previous proposal, I just posted
v4 at:
https://gcc.gnu.org/pipermail/gcc-patches/2022-August/600277.html
BR,
Kewen
prev parent reply other threads:[~2022-08-25 6:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 2:12 Kewen.Lin
2022-08-18 17:34 ` Segher Boessenkool
2022-08-19 2:40 ` Kewen.Lin
2022-08-23 14:33 ` Segher Boessenkool
2022-08-24 7:30 ` Kewen.Lin
2022-08-24 14:01 ` Segher Boessenkool
2022-08-25 6:02 ` Kewen.Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a25db3d6-a7f9-508b-9959-f702204cd0ca@linux.ibm.com \
--to=linkw@linux.ibm.com \
--cc=amodra@gmail.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).