public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: "Kewen.Lin" <linkw@linux.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
	David Edelsohn <dje.gcc@gmail.com>,  AlanM <amodra@gmail.com>
Subject: Re: [PATCH v3] rs6000: Rework ELFv2 support for -fpatchable-function-entry* [PR99888]
Date: Tue, 23 Aug 2022 09:33:10 -0500	[thread overview]
Message-ID: <20220823143310.GV25951@gate.crashing.org> (raw)
In-Reply-To: <db12ebf9-1f2f-1344-be62-66c87ac0cb5d@linux.ibm.com>

On Fri, Aug 19, 2022 at 10:40:10AM +0800, Kewen.Lin wrote:
> Since you proposed to update the documentation, I'm thinking if we can
> reconsider Fangrui's proposal in the PR which Alan seconded: Put preceding
> nops before GEP and succeeding nops after LEP.  Previously I had the concern
> that the nops inserted doesn't respect to a same function entry, it looks
> inconsistent to the documentation, and you also noted that "The nops have
> to be consecutive".  If we want to update the documentation, could we reword
> it for PowerPC ELFv2 ABI?
> 
> What's your opinion?

I'm not sure what the question is, sorry.

If you want different semantics for ELFv2 (which might well be useful),
we need some new command line option for that.

I suggested here to just describe in the existing doc what is done for
global and local entry points on ELFv2.


Segher

  reply	other threads:[~2022-08-23 14:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-18  2:12 Kewen.Lin
2022-08-18 17:34 ` Segher Boessenkool
2022-08-19  2:40   ` Kewen.Lin
2022-08-23 14:33     ` Segher Boessenkool [this message]
2022-08-24  7:30       ` Kewen.Lin
2022-08-24 14:01         ` Segher Boessenkool
2022-08-25  6:02           ` Kewen.Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220823143310.GV25951@gate.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=amodra@gmail.com \
    --cc=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=linkw@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).