From: Jonathan Wakely <jwakely@redhat.com>
To: gcc-patches@gcc.gnu.org
Subject: [PATCH 2/3] gcc: Fix nonportable shell syntax in "test" and "[" commands [PR105831]
Date: Thu, 18 May 2023 13:56:46 +0100 [thread overview]
Message-ID: <20230518125647.2105203-3-jwakely@redhat.com> (raw)
In-Reply-To: <20230518125647.2105203-1-jwakely@redhat.com>
POSIX sh does not support the == for string comparisons, use = instead.
The gen_directive_tests script uses a bash shebang so == does work, but
there's no reason this script can't just use the more portable form
anyway.
PR bootstrap/105831
gcc/ChangeLog:
* config.gcc: Use = operator instead of ==.
gcc/testsuite/ChangeLog:
* gcc.test-framework/gen_directive_tests: Use = operator instead
of ==.
---
gcc/config.gcc | 2 +-
gcc/testsuite/gcc.test-framework/gen_directive_tests | 12 ++++++------
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/gcc/config.gcc b/gcc/config.gcc
index e08c67d7cde..d88071773c9 100644
--- a/gcc/config.gcc
+++ b/gcc/config.gcc
@@ -2441,7 +2441,7 @@ riscv*-*-elf* | riscv*-*-rtems*)
tmake_file="${tmake_file} riscv/t-rtems"
;;
*)
- if test "x${with_multilib_generator}" == xdefault; then
+ if test "x${with_multilib_generator}" = xdefault; then
case "x${enable_multilib}" in
xno) ;;
xyes) tmake_file="${tmake_file} riscv/t-elf-multilib" ;;
diff --git a/gcc/testsuite/gcc.test-framework/gen_directive_tests b/gcc/testsuite/gcc.test-framework/gen_directive_tests
index 29f0a734877..87b3f3d1b40 100644
--- a/gcc/testsuite/gcc.test-framework/gen_directive_tests
+++ b/gcc/testsuite/gcc.test-framework/gen_directive_tests
@@ -283,8 +283,8 @@ one() {
echo "${GOOD_PROG}" >> $FILE1
echo "${GOOD_PROG}" > $FILE2
- if [ "${FAIL_VERSION}" == "yes" ]; then
- if [ "${EXP}" == "${EXP_PASS}" ]; then
+ if [ "${FAIL_VERSION}" = "yes" ]; then
+ if [ "${EXP}" = "${EXP_PASS}" ]; then
NAME=${KIND}-${EXP_FAIL}
else
NAME=${KIND}-${EXP_XFAIL}
@@ -322,8 +322,8 @@ two() {
echo "${GOOD_PROG}" >> $FILE1
echo "${GOOD_PROG}" > $FILE2
- if [ "${FAIL_VERSION}" == "yes" ]; then
- if [ "${EXP}" == "${EXP_PASS}" ]; then
+ if "yes" ]; then
+ if [ "${EXP}" = "${EXP_PASS}" ]; then
NAME=${KIND1}-${KIND2}-${EXP_FAIL}
else
NAME=${KIND1}-${KIND2}-${EXP_XFAIL}
@@ -364,8 +364,8 @@ three() {
echo "${GOOD_PROG}" >> $FILE1
echo "${GOOD_PROG}" > $FILE2
- if [ "${FAIL_VERSION}" == "${yes}" ]; then
- if [ "${EXP}" == "${EXP_PASS}" ]; then
+ if [ "${FAIL_VERSION}" = "${yes}" ]; then
+ if [ "${EXP}" = "${EXP_PASS}" ]; then
NAME=${KIND1}-${KIND2}-${KIND3}-${EXP_FAIL}
else
NAME=${KIND1}-${KIND2}-${KIND3}-${EXP_XFAIL}
--
2.40.1
next prev parent reply other threads:[~2023-05-18 12:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 12:56 [PATCH 0/3] Fix nonportable shell syntax in "test" and "[" commands Jonathan Wakely
2023-05-18 12:56 ` [PATCH 1/3] gcc: Fix nonportable shell syntax in "test" and "[" commands [PR105831] Jonathan Wakely
2023-05-18 13:00 ` Jakub Jelinek
2023-05-18 14:47 ` Bernhard Reutner-Fischer
2023-05-18 15:13 ` Jonathan Wakely
2023-05-18 12:56 ` Jonathan Wakely [this message]
2023-05-18 12:59 ` [PATCH 2/3] " Jakub Jelinek
2023-05-18 13:05 ` Jonathan Wakely
2023-05-18 13:03 ` [PATCH v2 " Jonathan Wakely
2023-05-18 13:15 ` Jakub Jelinek
2023-05-18 12:56 ` [PATCH 3/3] contrib: " Jonathan Wakely
2023-05-18 13:00 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230518125647.2105203-3-jwakely@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).