public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: gcc-patches@gcc.gnu.org, "Michael Bäuerle" <micha@netbsd.org>
Subject: Re: [PATCH 1/3] gcc: Fix nonportable shell syntax in "test" and "[" commands [PR105831]
Date: Thu, 18 May 2023 15:00:14 +0200	[thread overview]
Message-ID: <ZGYhXliXfUN+3Xja@tucnak> (raw)
In-Reply-To: <20230518125647.2105203-2-jwakely@redhat.com>

On Thu, May 18, 2023 at 01:56:45PM +0100, Jonathan Wakely via Gcc-patches wrote:
> From: Michael B??uerle <micha@NetBSD.org>
> 
> POSIX sh does not support the == for string comparisons, use = instead.
> 
> gcc/ChangeLog:
> 
> 	PR bootstrap/105831
> 	* config/nvptx/gen-opt.sh: Use = operator instead of ==.
> 	* configure.ac: Likewise.
> 	* configure: Regenerate.

LGTM.

	Jakub


  reply	other threads:[~2023-05-18 13:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-18 12:56 [PATCH 0/3] Fix nonportable shell syntax in "test" and "[" commands Jonathan Wakely
2023-05-18 12:56 ` [PATCH 1/3] gcc: Fix nonportable shell syntax in "test" and "[" commands [PR105831] Jonathan Wakely
2023-05-18 13:00   ` Jakub Jelinek [this message]
2023-05-18 14:47   ` Bernhard Reutner-Fischer
2023-05-18 15:13     ` Jonathan Wakely
2023-05-18 12:56 ` [PATCH 2/3] " Jonathan Wakely
2023-05-18 12:59   ` Jakub Jelinek
2023-05-18 13:05     ` Jonathan Wakely
2023-05-18 13:03   ` [PATCH v2 " Jonathan Wakely
2023-05-18 13:15     ` Jakub Jelinek
2023-05-18 12:56 ` [PATCH 3/3] contrib: " Jonathan Wakely
2023-05-18 13:00   ` Jakub Jelinek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZGYhXliXfUN+3Xja@tucnak \
    --to=jakub@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jwakely@redhat.com \
    --cc=micha@netbsd.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).